fix(notification): make security-critical mails non-suppressible#3850
Merged
Conversation
ACCOUNT_MERGE_REQUEST, CHANGED_MAIL, ADDED_ADDRESS and ACCOUNT_DEACTIVATION were mapped to MailContextType.INFO, causing them to be silently dropped for users whose wallet disables the Info mail type. These are mandatory account-blocking or security notifications and must always be delivered. Maps them to null (same as MONITORING/WEBHOOK/SEPA) so isDisabledMailWallet short-circuits and the mails bypass wallet mailConfig checks entirely. Closes #3842
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3842
Summary
ACCOUNT_MERGE_REQUEST,CHANGED_MAIL,ADDED_ADDRESS,ACCOUNT_DEACTIVATIONremapped fromMailContextType.INFOtonullnullcausesisDisabledMailWalletto short-circuit (mailContextType &&→ falsy), so these mails bypass walletmailConfigchecks entirely — same behaviour asMONITORING,WEBHOOK,SEPAMailContextTypeMappervalue type fromMailContextTypetoMailContextType | null(was already implicitly required by the existingnullentries)Why these four
ACCOUNT_MERGE_REQUESTCHANGED_MAILADDED_ADDRESSACCOUNT_DEACTIVATIONTest plan
InfoInfodisabledInfodisabledBLACK_SQUAD,LIMIT_REQUEST,CUSTOM,RECOMMENDATION_*(remain onINFO)