Release: develop -> main#21
Merged
Merged
Conversation
* test: add generic BitBox hardware simulation coverage * test: add reusable BitBox Flutter testkit * test: align full BitBox test gate * maintainer-edit: keep BLE packet dedup, narrow regression test to timeout This branch originally removed the iOS BLE per-packet dedup (Bluetooth.swift seenPackets set + contains-before-reset ordering) and replaced the protection with a comment-level contract that "the BLE bridge must keep request boundaries clean". The change reverses PR #15 (merged 2026-05-15, same day) which itself was a targeted fix to the dedup ordering. No rationale was provided in the PR description for why dedup is now unsafe/unnecessary, and the maintainer review pointed out that: * BLE/CoreBluetooth can deliver indications twice under poor RF conditions * U2FHID readFrame() has no SEQ validation * TestReadFrame_DuplicateContFrame_DesyncsFollowingMessage already demonstrates that a duplicated cont frame desyncs the next message * Buffer-clear between requests doesn't protect against duplicates arriving inside a single request-response cycle (which is the realistic failure mode under weak BLE) Pending an explicit rationale, keep the dedup. Maintainer-edit applied because the upstream author is unavailable. Reverted to develop state: - ios/Classes/Bluetooth.swift (dedup logic restored) - go/u2fhid/dedup_logic_test.go (algorithm regression test restored) - go/u2fhid/u2fhid_dedup_test.go (comments restored) Narrowed: - go/api/ios_bluetooth_regression_test.go now only guards the 60s read timeout (the uncontroversial fix), no longer forbids dedup patterns. The rest of the PR (Flutter testkit, Go fake-device harness, interface refactor, TESTING.md) is kept intact — that's all additive testing infrastructure and the actual value of this PR. * docs(testing): align "Fast PR gate" with actual CI workflow TESTING.md listed only `flutter analyze` + `flutter test` + `go test ./...` as the fast gate. The PR-checks workflow also runs `dart format --set-exit-if-changed` over lib + test + example and `go vet` + `go test -race -timeout 60s`. Without those, contributors run a green local check and still hit CI failures. Reproduce-CI-locally now reads exactly what `pull-request.yaml` runs. --------- Co-authored-by: TaprootFreak <142087526+TaprootFreak@users.noreply.github.com>
TaprootFreak
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist