Skip to content

Commit 49792b5

Browse files
fixed some issues
1 parent 3439290 commit 49792b5

2 files changed

Lines changed: 13 additions & 12 deletions

File tree

cmd/cli/llmSetup.go

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package cmd
22

33
import (
4-
4+
"errors"
55
"fmt"
66

77
"github.com/dfanso/commit-msg/cmd/cli/store"
@@ -24,12 +24,13 @@ func SetupLLM() error {
2424

2525
apiKeyPrompt := promptui.Prompt{
2626
Label: "Enter API Key",
27+
Mask: '*',
2728

2829
}
2930

3031
apiKey, err := apiKeyPrompt.Run()
3132
if err != nil {
32-
return fmt.Errorf("invalid API Key")
33+
return fmt.Errorf("failed to read API Key: %w", err)
3334
}
3435

3536
LLMConfig := store.LLMProvider{
@@ -55,9 +56,9 @@ func UpdateLLM() error {
5556
return err
5657
}
5758

58-
if len(SavedModels.LLMProviders) == 0{
59-
fmt.Println("No model exists, Please add atleast one model")
60-
return nil
59+
if len(SavedModels.LLMProviders) == 0 {
60+
return errors.New("no model exists, Please add atleast one model Run: 'commit llm setup'")
61+
6162
}
6263

6364
models := []string{}

cmd/cli/store/store.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,7 @@ func Save(LLMConfig LLMProvider) error {
4444
data, err := os.ReadFile(configPath)
4545
if errors.Is(err, os.ErrNotExist){
4646
data = []byte("{}")
47-
} else if
48-
err != nil {
47+
} else if err != nil {
4948
return err
5049
}
5150

@@ -166,16 +165,18 @@ func DefaultLLMKey() (*LLMProvider, error) {
166165
return nil, err
167166
}
168167

169-
170-
if len(data) > 0 {
168+
fmt.Println(len(data))
169+
if len(data) > 2 {
171170
err = json.Unmarshal(data, &cfg)
172171
if err != nil {
173172
return nil, err
174173
}
175174
} else {
176-
return nil, errors.New("config file is empty")
175+
return nil, errors.New("config file is empty, Please add atlead one LLM Key")
177176
}
178177

178+
179+
179180
defaultLLM := cfg.Default
180181

181182
for i, p := range cfg.LLMProviders {
@@ -289,8 +290,7 @@ func DeleteModel(Model string) error {
289290

290291
if Model == cfg.Default {
291292
if len(cfg.LLMProviders) > 1 {
292-
fmt.Println("Please set other model as default, Cant delete default model")
293-
return nil
293+
return fmt.Errorf("cannot delete %s while it is default, set other model default first", Model)
294294
} else {
295295
return os.WriteFile(configPath, []byte("{}"), 0600)
296296
}

0 commit comments

Comments
 (0)