Removed redundant code in client.go and removed the test file

Author: vinyas-bharadwaj

internal/http/client.go

@@ -15,22 +15,25 @@ var (
 	ollamaClient *http.Client
 )
 
+// createTransport creates a shared HTTP transport with optimized settings
+func createTransport() *http.Transport {
+	return &http.Transport{
+		TLSHandshakeTimeout: 10 * time.Second,
+		MaxIdleConns:        10,
+		IdleConnTimeout:     30 * time.Second,
+		DisableCompression:  true,
+		TLSClientConfig: &tls.Config{
+			InsecureSkipVerify: false,
+		},
+	}
+}
+
 // GetClient returns a shared HTTP client with optimized settings for cloud APIs
 func GetClient() *http.Client {
 	clientOnce.Do(func() {
-		transport := &http.Transport{
-			TLSHandshakeTimeout: 10 * time.Second,
-			MaxIdleConns:        10,
-			IdleConnTimeout:     30 * time.Second,
-			DisableCompression:  true,
-			TLSClientConfig: &tls.Config{
-				InsecureSkipVerify: false,
-			},
-		}
-
 		sharedClient = &http.Client{
 			Timeout:   30 * time.Second,
-			Transport: transport,
+			Transport: createTransport(),
 		}
 	})
 	return sharedClient
@@ -39,19 +42,9 @@ func GetClient() *http.Client {
 // GetOllamaClient returns an HTTP client with extended timeout for local Ollama inference
 func GetOllamaClient() *http.Client {
 	ollamaClientOnce.Do(func() {
-		transport := &http.Transport{
-			TLSHandshakeTimeout: 10 * time.Second,
-			MaxIdleConns:        10,
-			IdleConnTimeout:     30 * time.Second,
-			DisableCompression:  true,
-			TLSClientConfig: &tls.Config{
-				InsecureSkipVerify: false,
-			},
-		}
-
 		ollamaClient = &http.Client{
 			Timeout:   10 * time.Minute, // 10 minutes for local inference
-			Transport: transport,
+			Transport: createTransport(),
 		}
 	})
 	return ollamaClient