Performance optimizations

Author: juvander

Repository.ascx.cs

@@ -1763,15 +1763,16 @@ private void BindObjectList()
 
 				bool bIsPersonal = false;
 				bIsPersonal = false;
+                bool isAdministrator = PortalSecurity.IsInRole("Administrators");
 
-				if (Settings["IsPersonal"] != null) {
+                if (Settings["IsPersonal"] != null) {
 					bIsPersonal = bool.Parse(Settings["IsPersonal"].ToString());
 				}
 
 
 				if (bIsPersonal) {
 					foreach (RepositoryInfo dataitem in repositoryItems) {
-						if (int.Parse(dataitem.CreatedByUser) == UserId | PortalSecurity.IsInRole("Administrators")) {
+						if (int.Parse(dataitem.CreatedByUser) == UserId | isAdministrator) {
 							bindableList.Add(dataitem);
 						}
 					}
@@ -1789,7 +1790,7 @@ private void BindObjectList()
 							if (dataitem.SecurityRoles.StartsWith("U:")) {
 								string _targetUser = dataitem.SecurityRoles.Substring(2);
 								// admins see all items
-								if (string.IsNullOrEmpty(_targetUser) | PortalSecurity.IsInRole("Administrators")) {
+								if (string.IsNullOrEmpty(_targetUser) | isAdministrator) {
 									bindableList.Add(dataitem);
 								} else {
 									if (HttpContext.Current.User.Identity.IsAuthenticated) {
@@ -1933,6 +1934,7 @@ private bool CheckAnyUserRoles(string roles)
 					if (!string.IsNullOrEmpty(Item)) {
 						if (PortalSecurity.IsInRole(Item)) {
 							found = true;
+                            continue;
 						}
 					}
 				}

RepositoryDashboard.ascx.cs

@@ -623,6 +623,7 @@ private bool CheckAnyUserRoles(string roles)
 					if (!string.IsNullOrEmpty(Item)) {
 						if (PortalSecurity.IsInRole(Item)) {
 							found = true;
+                            continue;
 						}
 					}
 				}
@@ -654,20 +655,25 @@ private ArrayList RecalcCategoryCount(ArrayList categories)
 			ArrayList repositoryItems = repository.GetRepositoryObjects(m_RepositoryId, "", "Downloads", 1, -1, "", -1);
 			ArrayList bindableList = new ArrayList();
 			LoadBindableList(bIsPersonal, repositoryItems, bindableList);
-
-			// recalc the category counts
-			foreach (RepositoryCategoryInfo category in categories) {
-				foreach (RepositoryInfo item in bindableList) {
-					ArrayList cats = rc.GetRepositoryObjectCategories(item.ItemId);
-					foreach (RepositoryObjectCategoriesInfo _cat in cats) {
-						if (_cat.CategoryID == category.ItemId) {
-							category.Count = category.Count + 1;
-						}
-					}
-				}
-			}
-
-			return categories;
+            
+            // recalc the category counts
+            foreach (RepositoryInfo item in bindableList)
+            {
+                ArrayList cats = rc.GetRepositoryObjectCategories(item.ItemId);
+                foreach (RepositoryObjectCategoriesInfo _cat in cats)
+                {
+                    foreach (RepositoryCategoryInfo category in categories)
+                    {
+                        if (_cat.CategoryID == category.ItemId)
+                        {
+                            category.Count = category.Count + 1;
+                        }
+                    }
+                }
+            }
+            
+
+            return categories;
 
 		}
 
@@ -761,10 +767,12 @@ private void BindData()
 		}
 
 		private void LoadBindableList(bool bIsPersonal, ArrayList repositoryItems, ArrayList bindableList)
-		{
-			if (bIsPersonal) {
-				foreach (RepositoryInfo dataitem in repositoryItems) {
-					if (int.Parse(dataitem.CreatedByUser) == UserId | PortalSecurity.IsInRole("Administrators")) {
+        {
+            if (bIsPersonal)
+            {
+                bool isAdministrator = PortalSecurity.IsInRole("Administrators");
+                foreach (RepositoryInfo dataitem in repositoryItems) {
+					if (int.Parse(dataitem.CreatedByUser) == UserId | isAdministrator) {
 						bindableList.Add(dataitem);
 					}
 				}