Skip to content

Commit dd98537

Browse files
committed
Fix NWIS test regression and resolve WQP DtypeWarning
1 parent cbf7075 commit dd98537

2 files changed

Lines changed: 10 additions & 8 deletions

File tree

dataretrieval/wqp.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ def get_results(
154154

155155
response = query(url, kwargs, delimiter=";", ssl_check=ssl_check)
156156

157-
df = pd.read_csv(StringIO(response.text), delimiter=",")
157+
df = pd.read_csv(StringIO(response.text), delimiter=",", low_memory=False)
158158
return df, WQP_Metadata(response)
159159

160160

@@ -208,7 +208,7 @@ def what_sites(
208208

209209
response = query(url, payload=kwargs, delimiter=";", ssl_check=ssl_check)
210210

211-
df = pd.read_csv(StringIO(response.text), delimiter=",")
211+
df = pd.read_csv(StringIO(response.text), delimiter=",", low_memory=False)
212212

213213
return df, WQP_Metadata(response)
214214

@@ -263,7 +263,7 @@ def what_organizations(
263263

264264
response = query(url, payload=kwargs, delimiter=";", ssl_check=ssl_check)
265265

266-
df = pd.read_csv(StringIO(response.text), delimiter=",")
266+
df = pd.read_csv(StringIO(response.text), delimiter=",", low_memory=False)
267267

268268
return df, WQP_Metadata(response)
269269

@@ -314,7 +314,7 @@ def what_projects(ssl_check=True, legacy=True, **kwargs):
314314

315315
response = query(url, payload=kwargs, delimiter=";", ssl_check=ssl_check)
316316

317-
df = pd.read_csv(StringIO(response.text), delimiter=",")
317+
df = pd.read_csv(StringIO(response.text), delimiter=",", low_memory=False)
318318

319319
return df, WQP_Metadata(response)
320320

@@ -378,7 +378,7 @@ def what_activities(
378378

379379
response = query(url, payload=kwargs, delimiter=";", ssl_check=ssl_check)
380380

381-
df = pd.read_csv(StringIO(response.text), delimiter=",")
381+
df = pd.read_csv(StringIO(response.text), delimiter=",", low_memory=False)
382382

383383
return df, WQP_Metadata(response)
384384

@@ -440,7 +440,7 @@ def what_detection_limits(
440440

441441
response = query(url, payload=kwargs, delimiter=";", ssl_check=ssl_check)
442442

443-
df = pd.read_csv(StringIO(response.text), delimiter=",")
443+
df = pd.read_csv(StringIO(response.text), delimiter=",", low_memory=False)
444444

445445
return df, WQP_Metadata(response)
446446

@@ -495,7 +495,7 @@ def what_habitat_metrics(
495495

496496
response = query(url, payload=kwargs, delimiter=";", ssl_check=ssl_check)
497497

498-
df = pd.read_csv(StringIO(response.text), delimiter=",")
498+
df = pd.read_csv(StringIO(response.text), delimiter=",", low_memory=False)
499499

500500
return df, WQP_Metadata(response)
501501

@@ -551,7 +551,7 @@ def what_project_weights(ssl_check=True, legacy=True, **kwargs):
551551

552552
response = query(url, payload=kwargs, delimiter=";", ssl_check=ssl_check)
553553

554-
df = pd.read_csv(StringIO(response.text), delimiter=",")
554+
df = pd.read_csv(StringIO(response.text), delimiter=",", low_memory=False)
555555

556556
return df, WQP_Metadata(response)
557557

tests/nwis_test.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,8 @@ def test_iv_service_answer(requests_mock):
6161
DATETIME_COL,
6262
], f"iv service returned incorrect index: {df.index.names}"
6363

64+
65+
def test_nwis_service_live():
6466
"""Live sanity check of NWIS service, tolerant of transient NWIS outages."""
6567
site = "01491000"
6668
try:

0 commit comments

Comments
 (0)