Skip to content

Commit fd013ff

Browse files
committed
Ruff
1 parent 14a56f4 commit fd013ff

3 files changed

Lines changed: 38 additions & 18 deletions

File tree

dataretrieval/nwis.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,6 @@ def get_dv(
494494
return format_response(df, **kwargs), NWIS_Metadata(response, **kwargs)
495495

496496

497-
498497
def get_info(ssl_check: bool = True, **kwargs) -> tuple[pd.DataFrame, BaseMetadata]:
499498
"""
500499
Get site description information from NWIS.
@@ -688,7 +687,6 @@ def get_iv(
688687
return format_response(df, **kwargs), NWIS_Metadata(response, **kwargs)
689688

690689

691-
692690
def get_pmcodes(
693691
parameterCd: str | list[str] = "All",
694692
partial: bool = True,

dataretrieval/utils.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,6 @@ def query(url, payload, delimiter=",", ssl_check=True):
218218
+ f"The service at {response.url} may be down or experiencing issues."
219219
)
220220

221-
222221
if response.text.startswith("No sites/data"):
223222
raise NoSitesError(response.url)
224223

tests/nwis_test.py

Lines changed: 38 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ def _test_iv_service(requests_mock):
3232
end = END_DATE
3333
service = "iv"
3434
site = ["03339000", "05447500", "03346500"]
35-
35+
3636
# Minimal mock response
3737
mock_url = (
3838
"https://waterservices.usgs.gov/nwis/iv?format=json&"
@@ -44,20 +44,48 @@ def _test_iv_service(requests_mock):
4444
"timeSeries": [
4545
{
4646
"sourceInfo": {"siteCode": [{"value": "03339000"}]},
47-
"variable": {"variableCode": [{"value": "00060"}], "options": {"option": [{"value": "mean"}]}},
48-
"values": [{"method": [{"methodDescription": "mean"}], "value": [{"value": "1.0", "dateTime": "2018-01-24T00:00:00Z", "qualifiers": "A"}]}]
47+
"variable": {
48+
"variableCode": [{"value": "00060"}],
49+
"options": {"option": [{"value": "mean"}]},
50+
},
51+
"values": [
52+
{
53+
"method": [{"methodDescription": "mean"}],
54+
"value": [
55+
{
56+
"value": "1.0",
57+
"dateTime": "2018-01-24T00:00:00Z",
58+
"qualifiers": "A",
59+
}
60+
],
61+
}
62+
],
4963
},
5064
{
5165
"sourceInfo": {"siteCode": [{"value": "05447500"}]},
52-
"variable": {"variableCode": [{"value": "00060"}], "options": {"option": [{"value": "mean"}]}},
53-
"values": [{"method": [{"methodDescription": "mean"}], "value": [{"value": "2.0", "dateTime": "2018-01-24T00:00:00Z", "qualifiers": "A"}]}]
54-
}
66+
"variable": {
67+
"variableCode": [{"value": "00060"}],
68+
"options": {"option": [{"value": "mean"}]},
69+
},
70+
"values": [
71+
{
72+
"method": [{"methodDescription": "mean"}],
73+
"value": [
74+
{
75+
"value": "2.0",
76+
"dateTime": "2018-01-24T00:00:00Z",
77+
"qualifiers": "A",
78+
}
79+
],
80+
}
81+
],
82+
},
5583
]
5684
}
5785
}
5886

5987
requests_mock.get(mock_url, json=mock_json)
60-
88+
6189
return get_record(site, start, end, service=service)
6290

6391

@@ -88,7 +116,6 @@ def test_nwis_service_live():
88116
raise e
89117

90118

91-
92119
def test_preformat_peaks_response():
93120
# make a data frame with a "peak_dt" datetime column
94121
# it will have some nan and none values
@@ -154,7 +181,6 @@ def test_get_record_defunct_service_water_use(self):
154181
get_record(service="water_use")
155182

156183

157-
158184
class TestTZ:
159185
"""Tests relating to GitHub Issue #60."""
160186

@@ -232,19 +258,16 @@ def test_empty_timeseries(requests_mock):
232258
sites = "011277906"
233259
start = "2010-07-20"
234260
end = "2010-07-20"
235-
261+
236262
mock_url = (
237263
f"https://waterservices.usgs.gov/nwis/iv?format=json&"
238264
f"startDT={start}&endDT={end}&sites={sites}"
239265
)
240266
mock_json = {"value": {"timeSeries": []}}
241267
requests_mock.get(mock_url, json=mock_json)
242-
243-
df = get_record(
244-
sites=sites, service="iv", start=start, end=end
245-
)
246-
assert df.empty is True
247268

269+
df = get_record(sites=sites, service="iv", start=start, end=end)
270+
assert df.empty is True
248271

249272

250273
class TestMetaData:

0 commit comments

Comments
 (0)