Added test for unparsable date sent to constructor.

Author: michaeldrennen

src/ClientDailyPriceFixedIncome.php

@@ -2,6 +2,7 @@
 namespace DPRMC\InteractiveData;
 
 use DPRMC\CUSIP;
+use DPRMC\InteractiveData\RemotePlusClient\Exceptions\UnparsableDateSentToConstructor;
 
 /**
  * Class ClientDailyPriceFixedIncome
@@ -53,16 +54,11 @@ public function __construct( $user, $pass, $date, $cusips, $debug = FALSE ) {
      */
     protected function formatDateForRemotePlus( $date ) {
         $strTime = strtotime( $date );
-        if ( $strTime === FALSE ) {
-            throw new \Exception( "We could not parse the date you sent to the constructor: [" . $date . "]" );
-        }
-
+        if ( $strTime === FALSE ):
+            throw new UnparsableDateSentToConstructor( "We could not parse the date you sent to the constructor: [" . $date . "]" );
+        endif;
         $date = date( 'Ymd', $strTime );
 
-        if ( $date === FALSE ) {
-            throw new \Exception( "We were unable to format this timestamp into something Remote Plus can read: [" . $strTime . "]" );
-        }
-
         return $date;
     }
 
@@ -76,13 +72,13 @@ protected function formatDateForRemotePlus( $date ) {
      */
     protected function pruneInvalidCusips( $cusips ) {
         $validCusips = [];
-        foreach ( $cusips as $cusip ) {
-            if ( CUSIP::isCUSIP( $cusip ) ) {
+        foreach ( $cusips as $cusip ):
+            if ( CUSIP::isCUSIP( $cusip ) ):
                 $validCusips[] = $cusip;
-            } else {
+            else:
                 $this->invalidCusips[] = $cusip;
-            }
-        }
+            endif;
+        endforeach;
 
         return $validCusips;
     }

src/Exceptions/UnparsableDateSentToConstructor.php

@@ -0,0 +1,8 @@
+<?php
+namespace DPRMC\InteractiveData\RemotePlusClient\Exceptions;
+
+use Exception;
+
+class UnparsableDateSentToConstructor extends Exception {
+
+}

tests/ClientDailyPriceFixedIncomeTest.php

@@ -2,16 +2,22 @@
 namespace DPRMC\InteractiveData\RemotePlusClient\Tests;
 
 use DPRMC\InteractiveData\ClientDailyPriceFixedIncome;
+use DPRMC\InteractiveData\RemotePlusClient\Exceptions\UnparsableDateSentToConstructor;
 use GuzzleHttp\Exception\ClientException;
 use PHPUnit\Framework\TestCase;
 
 class ClientDailyPriceFixedIncomeTest extends TestCase {
 
-    public function testConstruct() {
+    public function testConstructor() {
         $client = new ClientDailyPriceFixedIncome( 'user', 'pass', '2017-07-31', [ '38259P508' ], FALSE );
         $this->assertInstanceOf( ClientDailyPriceFixedIncome::class, $client );
     }
 
+    public function testConstructorWithUnparsableDate() {
+        $this->expectException( UnparsableDateSentToConstructor::class );
+        new ClientDailyPriceFixedIncome( 'user', 'pass', 'this is not a date', [ '38259P508' ], FALSE );
+    }
+
     public function testRunWithInvalidCredentials() {
         $this->expectException( ClientException::class );
         $client   = new ClientDailyPriceFixedIncome( 'user', 'pass', '2017-07-31', [ '38259P508' ], FALSE );