fix periods (#118)

Author: mittal-ishaan

home/admin.py

@@ -906,7 +906,7 @@ def email(self, obj):
     def name(self, obj):
         return obj.email.name if obj.email else ""
 
-    actions = ["export_as_csv", "correct_bills", "fix_issue"]
+    actions = ["export_as_csv", "correct_bills", "fix_issue", "fix_period"]
 
     def export_as_csv(self, request, queryset):
         """
@@ -938,6 +938,14 @@ def fix_issue(self, request, queryset):
             obj.caterer = caterer
             obj.save()
 
+    def fix_period(self, request, queryset):
+        for obj in queryset:
+            if obj.period is None:
+                obj.period = Period.objects.get(
+                    Sno=3, semester=Semester.objects.get(name="Spring 2025")
+                )
+                obj.save()
+
     export_as_csv.short_description = "Export Allocation details to CSV"
 
 
@@ -1102,7 +1110,7 @@ class about_Admin(ImportExportModelAdmin, admin.ModelAdmin):
     model = AllocationForm
     search_fields = ("start_time", "end_time", "heading", "period__Sno")
     list_filter = ("start_time", "end_time", "heading", "period__Sno")
-    list_display = ("__str__", "start_time", "end_time", "active")
+    list_display = ("__str__", "start_time", "end_time", "active", "period")
     fieldsets = (
         (
             None,

home/migrations/0006_alter_allocationform_period.py

@@ -0,0 +1,19 @@
+# Generated by Django 5.0.8 on 2025-02-25 08:54
+
+import django.db.models.deletion
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('home', '0005_alter_studentbills_email'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='allocationform',
+            name='period',
+            field=models.ForeignKey(blank=True, on_delete=django.db.models.deletion.CASCADE, to='home.period'),
+        ),
+    ]

home/models/students.py

@@ -249,7 +249,7 @@ class AllocationForm(models.Model):
         _("heading"), max_length=100, default="", null=True, blank=True
     )
     description = models.TextField(_("description"), default="", null=True, blank=True)
-    period = models.ForeignKey(Period, on_delete=models.SET_NULL, null=True, blank=True)
+    period = models.ForeignKey(Period, on_delete=models.CASCADE, null=False, blank=True)
     active = models.BooleanField(_("active"), default=False, null=True, blank=True)
     start_time = models.DateTimeField(
         _("Start Time"), default=now, null=True, blank=True

home/signals.py

@@ -158,7 +158,7 @@ def update_long_bill(sender, instance: LongRebate, **kwargs):
 
 
 @receiver(post_save, sender=Allocation)
-def update_rebate_bill(sender, instance, created, **kwargs):
+def update_rebate_bill(sender, instance: Allocation, created, **kwargs):
     try:
         if created:
             sno = instance.period.Sno