Skip to content

Commit ffe28de

Browse files
Return error response if student photo is not available in QRVerifyUpdateView
1 parent 4d840f1 commit ffe28de

1 file changed

Lines changed: 2 additions & 9 deletions

File tree

api/views.py

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -174,15 +174,8 @@ def post(self, request):
174174
try:
175175
card = MessCard.objects.get(id=card_id)
176176
card_return_data = QRVerifySerializer(card).data
177-
try:
178-
if not card_return_data.get('student').get('photo'):
179-
user = User.objects.get(email=card.student.email)
180-
socialaccount_obj = SocialAccount.objects.filter(
181-
provider="google", user_id=user.id
182-
)
183-
card_return_data['student']['photo'] = socialaccount_obj[0].extra_data.get('picture')
184-
except:
185-
pass
177+
if not card_return_data.get('student').get('photo'):
178+
return Response({"success": False, "detail": "Student photo not available.", "mess_card": card_return_data}, status=status.HTTP_400_BAD_REQUEST)
186179
date = timezone.localtime().date()
187180
time = timezone.localtime().time()
188181
meal, _ = Meal.objects.get_or_create(mess_card=card, date=date)

0 commit comments

Comments
 (0)