Few Changes

* inline `RemoveFd`
* Rename `RemoveFd2` to `RemoveFd`
* Merge conditionals in `RenameAt2
* Remove debug info from releases

Author: DaisyDogs07

.github/workflows/build.yml

@@ -26,13 +26,13 @@ jobs:
         uses: egor-tensin/vs-shell@v2
 
       - name: Compile Library
-        run: cl /O2 /std:c++17 /LD /Zi FileSystem.cc
+        run: cl /O2 /std:c++17 /LD FileSystem.cc
 
       - name: Test Node.js Module
         run: npm i
 
       - name: Zip Library
-        run: powershell Compress-Archive -Path FileSystem.dll,FileSystem.lib,FileSystem.pdb,FileSystem.h,fsdef.h -DestinationPath FileSystem-windows.zip
+        run: powershell Compress-Archive -Path FileSystem.dll,FileSystem.lib,FileSystem.h,fsdef.h -DestinationPath FileSystem-windows.zip
 
       - name: Upload Library
         uses: actions/upload-artifact@v4
@@ -52,7 +52,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Compile Library
-        run: g++ -O2 -g -fPIC -shared -o FileSystem.so FileSystem.cc
+        run: g++ -O2 -fPIC -shared -o FileSystem.so FileSystem.cc
 
       - name: Test Node.js Module
         run: npm i

FileSystem.cc

@@ -797,7 +797,7 @@ namespace {
     ++fs->fdCount;
     return fdNum;
   }
-  void RemoveFd2(struct FSInternal* fs, struct Fd* fd, int i) {
+  void RemoveFd(struct FSInternal* fs, struct Fd* fd, int i) {
     struct BaseINode* inode = fd->inode;
     if (inode->nlink == 0)
       RemoveINode(fs, inode);
@@ -813,24 +813,6 @@ namespace {
     Realloc(fs->fds, fs->fdCount, fs->fdCount - 1);
     --fs->fdCount;
   }
-  int RemoveFd(struct FSInternal* fs, unsigned int fd) {
-    if (fs->fdCount == 0)
-      return -FS_EBADF;
-    int low = 0;
-    int high = fs->fdCount - 1;
-    while (low <= high) {
-      int mid = low + ((high - low) / 2);
-      struct Fd* f = fs->fds[mid];
-      if (f->fd == fd) {
-        RemoveFd2(fs, f, mid);
-        return 0;
-      }
-      if (f->fd < fd)
-        low = mid + 1;
-      else high = mid - 1;
-    }
-    return -FS_EBADF;
-  }
   struct Fd* GetFd(struct FSInternal* fs, unsigned int fdNum) {
     if (fs->fdCount == 0)
       return NULL;
@@ -1251,7 +1233,22 @@ int FileSystem::Creat(const char* path, fs_mode_t mode) {
 int FileSystem::Close(unsigned int fd) {
   struct FSInternal* fs = (struct FSInternal*)data;
   ScopedLock lock(fs->mtx);
-  return RemoveFd(fs, fd);
+  if (fs->fdCount == 0)
+    return -FS_EBADF;
+  int low = 0;
+  int high = fs->fdCount - 1;
+  while (low <= high) {
+    int mid = low + ((high - low) / 2);
+    struct Fd* f = fs->fds[mid];
+    if (f->fd == fd) {
+      RemoveFd(fs, f, mid);
+      return 0;
+    }
+    if (f->fd < fd)
+      low = mid + 1;
+    else high = mid - 1;
+  }
+  return -FS_EBADF;
 }
 int FileSystem::CloseRange(unsigned int fd, unsigned int maxFd) {
   if (fd > maxFd)
@@ -1261,11 +1258,11 @@ int FileSystem::CloseRange(unsigned int fd, unsigned int maxFd) {
   for (int i = 0; i != fs->fdCount; ++i) {
     struct Fd* f = fs->fds[i];
     if (f->fd >= fd) {
-      RemoveFd2(fs, f, i);
+      RemoveFd(fs, f, i);
       while (i != fs->fdCount) {
         f = fs->fds[i];
         if (f->fd < maxFd)
-          RemoveFd2(fs, f, i);
+          RemoveFd(fs, f, i);
         else break;
       }
       break;
@@ -1694,10 +1691,13 @@ int FileSystem::RenameAt2(
     return res;
   if (oldInode == newInode)
     return 0;
-  if (flags & FS_RENAME_NOREPLACE && newInode)
-    return -FS_EEXIST;
-  if (flags & FS_RENAME_EXCHANGE && !newInode)
-    return -FS_ENOENT;
+  if (newInode) {
+    if (flags & FS_RENAME_NOREPLACE)
+      return -FS_EEXIST;
+  } else {
+    if (flags & FS_RENAME_EXCHANGE)
+      return -FS_ENOENT;
+  }
   if (FS_S_ISDIR(oldInode->mode)) {
     if (newInode) {
       if (!FS_S_ISDIR(newInode->mode))

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@daisydogs07/filesystem",
-  "version": "5.2.9",
+  "version": "5.2.10",
   "os": ["linux", "win32"],
   "cpu": ["x64"],
   "keywords": [