Code revised with reactor

Applied rules:
 * ForRepeatedCountToOwnVariableRector
 * IssetOnPropertyObjectToPropertyExistsRector

Author: DanProgs

lib/api/xmlrpc/v1/xmlrpc.class.php

@@ -4752,7 +4752,7 @@ public function createTestSuite($args)
     {
         $result = array();
         $this->_setArgs($args);
-        $action = isset($this->args, self::$actionParamName) ? $this->args[self::$actionParamName] : 'create';
+        $action = $this->args !== null ? $this->args[self::$actionParamName] : 'create';
 
         $checkFunctions = array(
             'authenticate',
@@ -6934,7 +6934,7 @@ public function createTestCaseSteps($args)
 
                 $step_id = 0;
                 $stepSet = null;
-                $action = isset($this->args, self::$actionParamName) ? $this->args[self::$actionParamName] : 'create';
+                $action = $this->args !== null ? $this->args[self::$actionParamName] : 'create';
 
                 //
                 // id,step_number,actions,expected_results,active,execution_type

lib/functions/attachments.inc.php

@@ -111,8 +111,9 @@ function checkAttachmentID(&$db, $id, $attachmentInfo)
 {
     $isValid = false;
     if ($attachmentInfo) {
-        $sLastAttachmentInfos = isset($_SESSION['s_lastAttachmentInfos']) ? $_SESSION['s_lastAttachmentInfos'] : null;
-        for ($i = 0; $i < count($sLastAttachmentInfos); $i ++) {
+        $sLastAttachmentInfos = isset($_SESSION['s_lastAttachmentInfos']) ? $_SESSION['s_lastAttachmentInfos'] : null;
+        $counter = count($sLastAttachmentInfos);
+        for ($i = 0; $i < $counter; $i ++) {
             $info = $sLastAttachmentInfos[$i];
             if ($info['id'] == $id) {
                 $isValid = true;

lib/functions/code_testing/dBug.php

@@ -334,8 +334,9 @@ public function varIsDBResource($var, $db = "mysql")
         $this->makeTableHeader("resource", $db . " result", $numfields + 1);
         echo "<tr><td class=\"dBug_resourceKey\">&nbsp;</td>";
         for ($i = 0; $i < $numfields; $i ++) {
-            $field_header = "";
-            for ($j = 0; $j < count($arrFields); $j ++) {
+            $field_header = "";
+            $counter = count($arrFields);
+            for ($j = 0; $j < $counter; $j ++) {
                 $db_func = $db . "_field_" . $arrFields[$j];
                 if (function_exists($db_func)) {
                     $fheader = call_user_func($db_func, $var, $i) . " ";

lib/functions/metastring.class.php

@@ -181,8 +181,9 @@ public function localize($locale = null)
 
         $subjects = array();
         $replacements = array();
-        $params = (array) $this->helper->params;
-        for ($i = 0; $i < count($params); $i ++) {
+        $params = (array) $this->helper->params;
+        $counter = count($params);
+        for ($i = 0; $i < $counter; $i ++) {
             $param = $params[$i];
             if (is_array($param)) {
                 $item = null;

lib/functions/object.class.php

@@ -99,7 +99,7 @@ abstract class tlObject implements iSerialization
      */
     public function __construct()
     {
-        if (! isset($this->tables)) {
+        if ($this->tables === null) {
             $this->tables = self::getDBTables();
             $this->views = self::getDBViews();
         }
@@ -642,7 +642,8 @@ public static function createObjectsFromDB(&$db, $ids, $className,
             $items = self::bulkCreateObjectsFromDB($db, $ids, $className,
                 $returnAsMap, $detailLevel);
         } else {
-            for ($i = 0; $i < count((array) $ids); $i ++) {
+            $counter = count((array) $ids);
+            for ($i = 0; $i < $counter; $i ++) {
                 $id = $ids[$i];
                 $item = self::createObjectFromDB($db, $id, $className,
                     self::TLOBJ_O_SEARCH_BY_ID, $detailLevel);

lib/functions/string_api.php

@@ -74,8 +74,9 @@ function string_nl2br($p_string, $p_wrap = 100)
 
     // fix up eols within <pre> tags
     $pre2 = array();
-    preg_match_all("/<pre[^>]*?>(.|\n)*?<\/pre>/", $p_string, $pre1);
-    for ($x = 0; $x < count($pre1[0]); $x ++) {
+    preg_match_all("/<pre[^>]*?>(.|\n)*?<\/pre>/", $p_string, $pre1);
+    $counter = count($pre1[0]);
+    for ($x = 0; $x < $counter; $x ++) {
         $pre2[$x] = preg_replace("/<br[^>]*?>/", "", $pre1[0][$x]);
         // this may want to be replaced by html_entity_decode (or equivalent)
         // if other encoded characters are a problem

lib/functions/testproject.class.php

@@ -1407,8 +1407,9 @@ public function exportKeywordsToXML($testproject_id, $bNoXMLHeader = false)
         if (! $bNoXMLHeader) {
             $xmlCode .= TL_XMLEXPORT_HEADER . "\n";
         }
-        $xmlCode .= "<keywords>";
-        for ($idx = 0; $idx < count($kwIDs); $idx ++) {
+        $xmlCode .= "<keywords>";
+        $counter = count($kwIDs);
+        for ($idx = 0; $idx < $counter; $idx ++) {
             $keyword = new tlKeyword($kwIDs[$idx]);
             $keyword->readFromDb($this->db);
             $keyword->writeToXML($xmlCode, true);
@@ -1426,8 +1427,9 @@ public function exportKeywordsToXML($testproject_id, $bNoXMLHeader = false)
     private function exportKeywordsToCSV($testproject_id, $delim = ';')
     {
         $kwIDs = $this->getKeywordIDsFor($testproject_id);
-        $csv = null;
-        for ($idx = 0; $idx < count($kwIDs); $idx ++) {
+        $csv = null;
+        $counter = count($kwIDs);
+        for ($idx = 0; $idx < $counter; $idx ++) {
             $keyword = new tlKeyword($kwIDs[$idx]);
             $keyword->readFromDb($this->db);
             $keyword->writeToCSV($csv, $delim);

lib/functions/tlAttachmentRepository.class.php

@@ -518,9 +518,10 @@ public function deleteAttachmentsFor($fkid, $fkTableName)
         $stdTableUsedAsFolder = str_replace(DB_TABLE_PREFIX, '', $fkTableName);
         $statusOK = true;
         $attachmentIDs = (array) $this->getAttachmentIDsFor($fkid,
-            $stdTableUsedAsFolder);
+            $stdTableUsedAsFolder);
+        $counter = count($attachmentIDs);
 
-        for ($i = 0; $i < count($attachmentIDs); $i ++) {
+        for ($i = 0; $i < $counter; $i ++) {
             $id = $attachmentIDs[$i];
             $statusOK = ($this->deleteAttachment($id) && $statusOK);
         }

lib/functions/tlRole.class.php

@@ -506,8 +506,9 @@ protected function readRights(&$db)
 
     protected function buildRightsArray($rightInfo)
     {
-        $rights = null;
-        for ($i = 0; $i < count($rightInfo); $i ++) {
+        $rights = null;
+        $counter = count($rightInfo);
+        for ($i = 0; $i < $counter; $i ++) {
             $id = $rightInfo[$i];
             $right = new tlRight($id['right_id']);
             $right->name = $id['description'];

lib/functions/tlUser.class.php

@@ -1180,9 +1180,9 @@ public static function getByIDs(&$db, $ids,
 
         if (null == $ids) {
             return null;
-        }
-
-        for ($idx = 0; $idx < count($ids); $idx ++) {
+        }
+        $counter = count($ids);
+        for ($idx = 0; $idx < $counter; $idx ++) {
             $id = $ids[$idx];
             $user = tlDBObject::createObjectFromDB($db, $id, __CLASS__,
                 self::TLOBJ_O_SEARCH_BY_ID, $detailLevel);