Code revised with reactor

Applied rules:
 * RemoveNullPropertyInitializationRector
 * RemoveAlwaysElseRector

Author: DanProgs

firstLogin.php

@@ -57,9 +57,8 @@
                 $url2go = "login.php?note=first";
                 redirect(TL_BASE_HREF . $url2go);
                 exit();
-            } else {
-                $message = getUserErrorMessage($result);
-            }
+            }
+            $message = getUserErrorMessage($result);
         } else {
             $message = $rx['msg'];
         }

install/installStart.php

@@ -2,14 +2,16 @@
 /* TestLink Open Source Project - http://testlink.sourceforge.net/ */
 /* $Id: installStart.php,v 1.2 2005/08/16 17:59:48 franciscom Exp $ */
 $installationType = $_GET['installationType'];
+if ($installationType=='new') {
+    header("Location: newInstallStart_TL.php");
+    exit;
+}
 
-if($installationType=='new') {
-	header("Location: newInstallStart_TL.php");
-	exit;
-} elseif($installationType=='upgrade') {
-	header("Location: upgradeStart.php");
-	exit;
-} else {
+if ($installationType=='upgrade') {
+    header("Location: upgradeStart.php");
+    exit;
+}
+else {
 	echo "No installationType found in \$_GET.";
 }
 

lib/api/rest/v1/tlRestApi.class.php

@@ -48,40 +48,40 @@ class tlRestApi
      *
      * @access protected
      */
-    protected $db = null;
+    protected $db;
 
-    protected $tables = null;
+    protected $tables;
 
-    protected $tcaseMgr = null;
+    protected $tcaseMgr;
 
-    protected $tprojectMgr = null;
+    protected $tprojectMgr;
 
-    protected $tsuiteMgr = null;
+    protected $tsuiteMgr;
 
-    protected $tplanMgr = null;
+    protected $tplanMgr;
 
-    protected $tplanMetricsMgr = null;
+    protected $tplanMetricsMgr;
 
-    protected $reqSpecMgr = null;
+    protected $reqSpecMgr;
 
-    protected $reqMgr = null;
+    protected $reqMgr;
 
-    protected $platformMgr = null;
+    protected $platformMgr;
 
     /**
      * userID associated with the apiKey provided
      */
-    protected $userID = null;
+    protected $userID;
 
     /**
      * UserObject associated with the userID
      */
-    protected $user = null;
+    protected $user;
 
     /**
      * array where all the args are stored for requests
      */
-    protected $args = null;
+    protected $args;
 
     /**
      * array where error codes and messages are stored
@@ -91,7 +91,7 @@ class tlRestApi
     /**
      * The api key being used to make a request
      */
-    protected $apiKey = null;
+    protected $apiKey;
 
     /**
      * boolean to allow a method to invoke another method and avoid double auth
@@ -107,9 +107,9 @@ class tlRestApi
     /**
      * _checkTCIDAndTPIDValid()
      */
-    protected $tcVersionID = null;
+    protected $tcVersionID;
 
-    protected $versionNumber = null;
+    protected $versionNumber;
 
     public $statusCode;
 

lib/api/rest/v2/tlRestApi.class.php

@@ -47,44 +47,44 @@ class tlRestApi
      *
      * @access protected
      */
-    protected $db = null;
+    protected $db;
 
-    protected $tables = null;
+    protected $tables;
 
-    protected $tcaseMgr = null;
+    protected $tcaseMgr;
 
-    protected $tprojectMgr = null;
+    protected $tprojectMgr;
 
-    protected $tsuiteMgr = null;
+    protected $tsuiteMgr;
 
-    protected $tplanMgr = null;
+    protected $tplanMgr;
 
-    protected $tplanMetricsMgr = null;
+    protected $tplanMetricsMgr;
 
-    protected $reqSpecMgr = null;
+    protected $reqSpecMgr;
 
-    protected $reqMgr = null;
+    protected $reqMgr;
 
-    protected $platformMgr = null;
+    protected $platformMgr;
 
-    protected $buildMgr = null;
+    protected $buildMgr;
 
-    protected $cfieldMgr = null;
+    protected $cfieldMgr;
 
     /**
      * userID associated with the apiKey provided
      */
-    protected $userID = null;
+    protected $userID;
 
     /**
      * UserObject associated with the userID
      */
-    protected $user = null;
+    protected $user;
 
     /**
      * array where all the args are stored for requests
      */
-    protected $args = null;
+    protected $args;
 
     /**
      * array where error codes and messages are stored
@@ -94,7 +94,7 @@ class tlRestApi
     /**
      * The api key being used to make a request
      */
-    protected $apiKey = null;
+    protected $apiKey;
 
     /**
      * boolean to allow a method to invoke another method and avoid double auth
@@ -107,9 +107,9 @@ class tlRestApi
     /**
      * This value is setted in following method:
      */
-    protected $tcVersionID = null;
+    protected $tcVersionID;
 
-    protected $versionNumber = null;
+    protected $versionNumber;
 
     protected $debugMsg;
 

lib/api/rest/v3/RestApi.class.php

@@ -49,44 +49,44 @@ class RestApi
      *
      * @access protected
      */
-    protected $db = null;
+    protected $db;
 
-    protected $tables = null;
+    protected $tables;
 
-    protected $tcaseMgr = null;
+    protected $tcaseMgr;
 
-    protected $tprojectMgr = null;
+    protected $tprojectMgr;
 
-    protected $tsuiteMgr = null;
+    protected $tsuiteMgr;
 
-    protected $tplanMgr = null;
+    protected $tplanMgr;
 
-    protected $tplanMetricsMgr = null;
+    protected $tplanMetricsMgr;
 
-    protected $reqSpecMgr = null;
+    protected $reqSpecMgr;
 
-    protected $reqMgr = null;
+    protected $reqMgr;
 
-    protected $platformMgr = null;
+    protected $platformMgr;
 
-    protected $buildMgr = null;
+    protected $buildMgr;
 
-    protected $cfieldMgr = null;
+    protected $cfieldMgr;
 
     /**
      * userID associated with the apiKey provided
      */
-    protected $userID = null;
+    protected $userID;
 
     /**
      * UserObject associated with the userID
      */
-    protected $user = null;
+    protected $user;
 
     /**
      * The api key being used to make a request
      */
-    protected $apiKey = null;
+    protected $apiKey;
 
     /**
      * boolean to allow a method to invoke another method and avoid double auth
@@ -99,9 +99,9 @@ class RestApi
     /**
      * This value is setted in following method:
      */
-    protected $tcVersionID = null;
+    protected $tcVersionID;
 
-    protected $versionNumber = null;
+    protected $versionNumber;
 
     protected $debugMsg;