Code revised with reactor

Applied rules:
 * RemoveUnusedForeachKeyRector
 * VarToPublicPropertyRector

Author: DanProgs

lib/functions/assignment_mgr.class.php

@@ -245,7 +245,7 @@ public function update($feature_map)
                 'creation_ts'
             );
 
-            foreach ($simple_fields as $idx => $field) {
+            foreach ($simple_fields as $field) {
                 if (isset($elem[$field])) {
                     $sql .= $sepa . "$field={$elem[$field]} ";
                     $sepa = ",";

lib/functions/code_testing/dBug.php

@@ -49,30 +49,30 @@
 class dBug
 {
 
-    var $xmlDepth = array();
+    public $xmlDepth = array();
 
-    var $xmlCData;
+    public $xmlCData;
 
-    var $xmlSData;
+    public $xmlSData;
 
-    var $xmlDData;
+    public $xmlDData;
 
-    var $xmlCount = 0;
+    public $xmlCount = 0;
 
-    var $xmlAttrib;
+    public $xmlAttrib;
 
-    var $xmlName;
+    public $xmlName;
 
-    var $arrType = array(
+    public $arrType = array(
         "array",
         "object",
         "resource",
         "boolean"
     );
 
-    var $bInitialized = false;
+    public $bInitialized = false;
 
-    var $arrHistory = array();
+    public $arrHistory = array();
 
     public function __construct($var, $forceType = "")
     {

lib/functions/testplan.class.php

@@ -1151,7 +1151,7 @@ public function unlink_tcversions($id, &$items)
         $platformLabel = lang_get('platform');
 
         $dummy = null;
-        foreach ($items['items'] as $tcase_id => $elem) {
+        foreach ($items['items'] as $elem) {
             foreach ($elem as $platform_id => $tcversion_id) {
                 $dummy[] = "(tcversion_id = {$tcversion_id} AND platform_id = {$platform_id})";
             }

lib/issuetrackerintegration/code_testing/redmine/test.redmine.rest.php

@@ -16,14 +16,14 @@
 class Issue extends ActiveResource
 {
 
-    var $site = 'http://testlink.m.redmine.org/';
+    public $site = 'http://testlink.m.redmine.org/';
 
-    var $request_format = 'xml';
+    public $request_format = 'xml';
 
     // REQUIRED!
-    var $user = 'testlink.redmine';
+    public $user = 'testlink.redmine';
 
-    var $password = 'redmine2012';
+    public $password = 'redmine2012';
 }
 
 // find issues