Merge branch 'qa-fixes' into 'enterprise'

misc qa fixes

See merge request dkinternal/testgen/dataops-testgen!263

Author: ci bot

testgen/ui/components/frontend/css/shared.css

@@ -149,6 +149,7 @@ body {
     border: var(--button-stroked-border);
     border-radius: 8px;
     padding: 16px;
+    box-sizing: border-box;
 }
 
 .table-row {

testgen/ui/components/frontend/js/pages/project_dashboard.js

@@ -157,7 +157,7 @@ const TableGroupCard = (/** @type TableGroupSummary */ tableGroup) => {
                     ),
                     span(
                         { class: 'text-caption mt-1 mb-3 tg-overview--subtitle' },
-                        `${tableGroup.latest_profile_table_ct} tables | ${tableGroup.latest_profile_column_ct} columns`,
+                        `${tableGroup.latest_profile_table_ct ?? 0} tables | ${tableGroup.latest_profile_column_ct ?? 0} columns`,
                     ),
                     TableGroupTestSuiteSummary(tableGroup.test_suites),
                 ),

testgen/ui/components/frontend/js/pages/schedule_list.js

@@ -19,7 +19,7 @@
 import van from '../van.min.js';
 import { Button } from '../components/button.js';
 import { Streamlit } from '../streamlit.js';
-import { emitEvent, getValue, resizeFrameHeightToElement } from '../utils.js';
+import { emitEvent, getValue, resizeFrameHeightToElement, resizeFrameHeightOnDOMChange } from '../utils.js';
 import { withTooltip } from '../components/tooltip.js';
 
 
@@ -42,6 +42,7 @@ const ScheduleList = (/** @type Properties */ props) => {
 
     const tableId = 'profiling-schedules-table';
     resizeFrameHeightToElement(tableId);
+    resizeFrameHeightOnDOMChange(tableId);
 
     return div(
         { class: 'table', id: tableId },

testgen/ui/components/frontend/js/pages/table_group_list.js

@@ -222,7 +222,7 @@ const Toolbar = (permissions, connections, selectedConnection) => {
                 })) ?? [],
                 onChange: (value) => emitEvent('ConnectionSelected', { payload: value }),
             })
-            : undefined,
+            : span(''),
         div(
             { class: 'flex-row fx-gap-4' },
             Button({

testgen/ui/services/form_service.py

@@ -1,3 +1,4 @@
+import json
 import typing
 from builtins import float
 from pathlib import Path
@@ -312,7 +313,7 @@ def render_grid_select(
         enable_enterprise_modules=False,
         allow_unsafe_jscode=True,
         update_mode=GridUpdateMode.NO_UPDATE,
-        update_on=["selectionChanged", "modelUpdated"],
+        update_on=["selectionChanged"],
         data_return_mode=DataReturnMode.FILTERED_AND_SORTED,
         columns_auto_size_mode=ColumnsAutoSizeMode.FIT_CONTENTS,
         height=int_height,
@@ -332,4 +333,13 @@ def render_grid_select(
     if len(selected_rows) > 0:
         if bind_to_query_name and bind_to_query_prop:
             Router().set_query_params({bind_to_query_name: selected_rows[0][bind_to_query_prop]})
+            
+            # We need to get the data from the original dataframe
+            # Otherwise changes to the dataframe (e.g., editing the current selection) do not get reflected in the returned rows
+            # Adding "modelUpdated" to AgGrid(update_on=...) does not work
+            # because it causes unnecessary reruns that cause dialogs to close abruptly
+            selected_props = [row[bind_to_query_prop] for row in selected_rows]
+            selected_df = df[df[bind_to_query_prop].isin(selected_props)]
+            selected_rows = json.loads(selected_df.to_json(orient="records"))
+
         return selected_rows

testgen/ui/views/profiling_results.py

@@ -10,6 +10,7 @@
 import testgen.ui.services.database_service as db
 import testgen.ui.services.form_service as fm
 from testgen.common import date_service
+from testgen.common.models import with_database_session
 from testgen.ui.components import widgets as testgen
 from testgen.ui.components.widgets.download_dialog import (
     FILE_DATA_TYPE,
@@ -171,6 +172,7 @@ def open_download_dialog(data: pd.DataFrame | None = None) -> None:
             )
 
 
+@with_database_session
 def get_excel_report_data(
     update_progress: PROGRESS_UPDATE_TYPE,
     table_group: str,
@@ -192,7 +194,7 @@ def get_excel_report_data(
 
     for key in ["min_date", "max_date"]:
         data[key] = data[key].apply(
-            lambda val: datetime.fromtimestamp(val / 1000).strftime("%b %-d %Y, %-I:%M %p") if not pd.isna(val) else None
+            lambda val: datetime.strptime(val, "%Y-%m-%d %H:%M:%S").strftime("%b %-d %Y, %-I:%M %p") if not pd.isna(val) and val != "NaT" else None
         )
 
     data["hygiene_issues"] = data["hygiene_issues"].apply(lambda val: "Yes" if val else None)