Skip to content

Commit 4dff068

Browse files
committed
fix(hygiene issues): sort by likelihood first
1 parent b3f1c90 commit 4dff068

3 files changed

Lines changed: 7 additions & 7 deletions

File tree

testgen/common/models/test_definition.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from dataclasses import dataclass
33
from datetime import datetime
44
from typing import Literal
5-
from uuid import UUID, uuid4
5+
from uuid import UUID
66

77
import streamlit as st
88
from sqlalchemy import (

testgen/ui/views/hygiene_issues.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ def render(
156156
("Likelihood", "likelihood_order"),
157157
("Action", "r.disposition"),
158158
)
159-
default = [(sortable_columns[i][1], "ASC") for i in (0, 1)]
159+
default = [(sortable_columns[i][1], "ASC") for i in (3, 0, 1)]
160160
sorting_columns = testgen.sorting_selector(sortable_columns, default)
161161

162162
with actions_column:
@@ -434,10 +434,10 @@ def get_profiling_anomalies(
434434
THEN 'Potential PII: may require privacy policies, standards and procedures for access, storage and transmission.'
435435
END AS likelihood_explanation,
436436
CASE
437-
WHEN t.issue_likelihood = 'Potential PII' THEN 1
438-
WHEN t.issue_likelihood = 'Possible' THEN 2
439-
WHEN t.issue_likelihood = 'Likely' THEN 3
440-
WHEN t.issue_likelihood = 'Definite' THEN 4
437+
WHEN t.issue_likelihood = 'Potential PII' THEN 4
438+
WHEN t.issue_likelihood = 'Possible' THEN 3
439+
WHEN t.issue_likelihood = 'Likely' THEN 2
440+
WHEN t.issue_likelihood = 'Definite' THEN 1
441441
END AS likelihood_order,
442442
t.anomaly_description, r.detail, t.suggested_action,
443443
r.anomaly_id, r.table_groups_id::VARCHAR, r.id::VARCHAR, p.profiling_starttime, r.profile_run_id::VARCHAR,

testgen/ui/views/test_results.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -805,7 +805,7 @@ def source_data_dialog(selected_row):
805805
st.caption(selected_row["test_description"])
806806

807807
st.markdown("#### Test Parameters")
808-
st.caption(selected_row["input_parameters"])
808+
testgen.caption(selected_row["input_parameters"], styles="max-height: 100px; overflow: auto;")
809809

810810
st.markdown("#### Result Detail")
811811
st.caption(selected_row["result_message"])

0 commit comments

Comments
 (0)