Skip to content

Commit 506ac5c

Browse files
author
ci bot
committed
Merge branch 'enable-score-type-switch' into 'enterprise'
misc(scoring): uncomment score type dropdown in breakdown table See merge request dkinternal/testgen/dataops-testgen!164
2 parents 5ffcc56 + 1c872ea commit 506ac5c

2 files changed

Lines changed: 15 additions & 6 deletions

File tree

testgen/ui/components/frontend/js/components/score_breakdown.js

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,16 @@ const ScoreBreakdown = (score, breakdown, category, scoreType, onViewDetails) =>
2626
onChange: (value) => emitEvent('CategoryChanged', { payload: value }),
2727
});
2828
},
29-
// span('for'),
30-
// () => Select({
31-
// label: '',
32-
// options: ['score', 'cde_score'].map((s) => ({ label: SCORE_TYPE_LABEL[s], value: s, selected: s === scoreType })),
33-
// onChange: (value) => emitEvent('ScoreTypeChanged', { payload: value }),
34-
// }),
29+
span('for'),
30+
() => {
31+
const selectedScoreType = getValue(scoreType);
32+
return Select({
33+
label: '',
34+
value: selectedScoreType,
35+
options: ['score', 'cde_score'].map((s) => ({ label: SCORE_TYPE_LABEL[s], value: s, selected: s === scoreType })),
36+
onChange: (value) => emitEvent('ScoreTypeChanged', { payload: value }),
37+
});
38+
},
3539
),
3640
() => ['table_name', 'column_name'].includes(getValue(category)) ? span('* Top 100 values by impact') : '',
3741
),

testgen/ui/views/score_explorer.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ def render(
118118
on_change_handlers={
119119
"ScoreUpdated": set_score_definition,
120120
"CategoryChanged": set_breakdown_category,
121+
"ScoreTypeChanged": set_breakdown_score_type,
121122
"DrilldownChanged": set_breakdown_drilldown,
122123
"IssueReportsExported": export_issue_reports,
123124
"ScoreDefinitionSaved": save_score_definition,
@@ -146,6 +147,10 @@ def set_breakdown_category(category: str) -> None:
146147
Router().set_query_params({"breakdown_category": category})
147148

148149

150+
def set_breakdown_score_type(score_type: str) -> None:
151+
Router().set_query_params({"breakdown_score_type": score_type})
152+
153+
149154
def set_breakdown_drilldown(drilldown: str | None) -> None:
150155
Router().set_query_params({"drilldown": drilldown})
151156

0 commit comments

Comments
 (0)