fix(quality-dashboard): scorecard display and sorting

Author: aarthy-dk

testgen/ui/components/frontend/js/pages/quality_dashboard.js

@@ -38,12 +38,23 @@ const QualityDashboard = (/** @type {Properties} */ props) => {
 
     const sortedBy = van.state('name');
     const filterTerm = van.state('');
+
+    const scoreToNumber = (score) => score ? (score.startsWith('>') ? 99.99 : Number(score)) : 101;
+    const sortFunctions = {
+        name: (a, b) => caseInsensitiveSort(a.name, b.name),
+        score: (a, b) => {
+            const scoreA = Math.min(scoreToNumber(a.score), scoreToNumber(a.cde_score));
+            const scoreB = Math.min(scoreToNumber(b.score), scoreToNumber(b.cde_score));
+            return scoreA - scoreB;
+        },
+    };
+
     const scores = van.derive(() => {
         const sort = getValue(sortedBy) ?? 'name';
         const filter = getValue(filterTerm) ?? '';
         return getValue(props.scores)
             .filter(score => caseInsensitiveIncludes(score.name, filter))
-            .sort((a, b) => caseInsensitiveSort(a[sort], b[sort]));
+            .sort(sortFunctions[sort]);
     });
 
     return div(

testgen/ui/queries/scoring_queries.py

@@ -9,7 +9,7 @@
 @st.cache_data(show_spinner="Loading data :gray[:small[(This might take a few minutes)]] ...")
 def get_all_score_cards(project_code: str) -> list["ScoreCard"]:
     results = [
-        definition.as_cached_score_card()
+        definition.as_cached_score_card(include_definition=True)
         for definition in ScoreDefinition.all(project_code=project_code, last_history_items=50)
     ]
     return results

testgen/ui/views/score_details.py

@@ -80,7 +80,7 @@ def render(
         issues = None
         with st.spinner(text="Loading data :gray[:small[(This might take a few minutes)]] ..."):
             user_can_edit = session.auth.user_has_permission("edit")
-            score_card = format_score_card(score_definition.as_cached_score_card())
+            score_card = format_score_card(score_definition.as_cached_score_card(include_definition=True))
             if score_type not in typing.get_args(ScoreTypes):
                 score_type = None
             if not score_type: