Merge branch 'qa-fixes' into 'enterprise'

Fix QA issues

See merge request dkinternal/testgen/dataops-testgen!211

Author: ci bot

testgen/common/models/scores.py

@@ -264,7 +264,13 @@ def get_score_card_breakdown(
             "column_name": ["table_groups_id", "table_name", "column_name"],
         }.get(group_by, [group_by])
         filters = " AND ".join(self._get_raw_query_filters(cde_only=score_type == "cde_score"))
-        join_condition = " AND ".join([f"test_records.{column} = profiling_records.{column}" for column in columns])
+
+        if group_by in ["table_groups_name", "table_name", "column_name"]:
+            join_condition = " AND ".join([f"test_records.{column} = profiling_records.{column}" for column in columns])
+        else:
+            join_condition = f"""(test_records.{group_by} = profiling_records.{group_by}
+                OR (test_records.{group_by} IS NULL 
+                AND profiling_records.{group_by} IS NULL))"""
 
         profile_records_filters = self._get_raw_query_filters(
             cde_only=score_type == "cde_score",

testgen/template/dbsetup/075_grant_role_rights.sql

@@ -37,7 +37,8 @@ GRANT SELECT, INSERT, DELETE, UPDATE ON
     {SCHEMA_NAME}.score_definition_results,
     {SCHEMA_NAME}.score_definition_results_breakdown,
     {SCHEMA_NAME}.score_definition_results_history,
-    {SCHEMA_NAME}.score_history_latest_runs
+    {SCHEMA_NAME}.score_history_latest_runs,
+    {SCHEMA_NAME}.job_schedules
     TO testgen_execute_role;
 
 

testgen/template/score_cards/get_score_card_breakdown_by_column.sql

@@ -7,8 +7,7 @@ profiling_records AS (
         SUM(record_ct) AS data_point_ct,
         SUM(record_ct * good_data_pct) / NULLIF(SUM(record_ct), 0) AS score
     FROM v_dq_profile_scoring_latest_by_column
-    WHERE NULLIF({group_by}, '') IS NOT NULL
-        AND {filters}
+    WHERE {filters}
     GROUP BY project_code, {columns}
 ),
 test_records AS (
@@ -19,8 +18,7 @@ test_records AS (
         SUM(dq_record_ct) AS data_point_ct,
         SUM(dq_record_ct * good_data_pct) / NULLIF(SUM(dq_record_ct), 0) AS score
     FROM v_dq_test_scoring_latest_by_column
-    WHERE NULLIF({group_by}, '') IS NOT NULL
-        AND {filters}
+    WHERE {filters}
     GROUP BY project_code, {columns}
 ),
 parent AS (

testgen/template/score_cards/get_score_card_breakdown_by_dimension.sql

@@ -7,8 +7,7 @@ profiling_records AS (
         SUM(record_ct) AS data_point_ct,
         SUM(record_ct * good_data_pct) / NULLIF(SUM(record_ct), 0) AS score
     FROM v_dq_profile_scoring_latest_by_dimension
-    WHERE NULLIF({group_by}, '') IS NOT NULL
-        AND {filters}
+    WHERE {filters}
     GROUP BY project_code, {columns}
 ),
 test_records AS (
@@ -19,8 +18,7 @@ test_records AS (
         SUM(dq_record_ct) AS data_point_ct,
         SUM(dq_record_ct * good_data_pct) / NULLIF(SUM(dq_record_ct), 0) AS score
     FROM v_dq_test_scoring_latest_by_dimension
-    WHERE NULLIF({group_by}, '') IS NOT NULL
-        AND {filters}
+    WHERE {filters}
     GROUP BY project_code, {columns}
 ),
 parent AS (

testgen/ui/components/frontend/js/components/score_breakdown.js

@@ -111,7 +111,7 @@ const TableCell = (row, column, score=undefined, category=undefined, scoreType=u
     const size = BREAKDOWN_COLUMNS_SIZES[column] ?? COLUMN_DEFAULT_SIZE;
     return div(
         { style: `flex: ${size}; max-width: ${size}; word-wrap: break-word;`, 'data-testid': 'score-breakdown-cell' },
-        span(row[column]),
+        span(row[column] ?? '-'),
     );
 };
 

testgen/ui/components/frontend/js/components/score_issues.js

@@ -311,6 +311,7 @@ const TimeCell = (value, row) => {
                 run_id: row.run_id,
                 table_name: row.table,
                 column_name: row.column,
+                selected: row.id,
             },
         }),
     );

testgen/ui/views/dialogs/run_profiling_dialog.py

@@ -65,7 +65,7 @@ def run_profiling_dialog(project_code: str, table_group: pd.Series | None = None
                 testgen.link(
                     label="Go to Profiling Runs",
                     href=LINK_HREF,
-                    params={ "table_group": table_group_id },
+                    params={ "project_code": project_code, "table_group": table_group_id },
                     right_icon="chevron_right",
                     underline=False,
                     height=40,

testgen/ui/views/dialogs/run_tests_dialog.py

@@ -69,7 +69,7 @@ def run_tests_dialog(project_code: str, test_suite: pd.Series | None = None, def
                 testgen.link(
                     label="Go to Test Runs",
                     href=LINK_HREF,
-                    params={ "test_suite": test_suite_id },
+                    params={ "project_code": project_code, "test_suite": test_suite_id },
                     right_icon="chevron_right",
                     underline=False,
                     height=40,

testgen/ui/views/score_details.py

@@ -187,7 +187,7 @@ def delete_score_card(definition_id: str) -> None:
     if delete_clicked():
         score_definition.delete()
         get_all_score_cards.clear()
-        Router().navigate("quality-dashboard")
+        Router().navigate("quality-dashboard", { "project_code": score_definition.project_code })
 
 
 def recalculate_score_history(definition_id: str) -> None:

testgen/ui/views/table_groups/page.py

@@ -98,7 +98,7 @@ def render(self, connection_id: str, **_kwargs) -> None:
                     testgen.link(
                         label="Test Suites",
                         href="test-suites",
-                        params={"table_group_id": table_group["id"]},
+                        params={ "project_code": project_code, "table_group_id": table_group["id"] },
                         right_icon="chevron_right",
                         key=f"tablegroups:keys:go-to-tsuites:{table_group['id']}",
                     )