release_connection after cleaning (#122)

For Rails >= 7.2, this library gets a connection via
`#lease_connection`. But it never releases the connection. Release the
connection back to the pool after `#clean`-ing.

Rails >= 7.2 does connection health checks / reconnect on connection
checkout. If the connection is never checked back into the pool, it will
never get "repaired", which makes testing database connection issues
tricky.

Author: nerdrew

.github/workflows/ci.yml

@@ -9,40 +9,47 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: ['3.3', '3.2', '3.1']
-        rails: ['6.1', '7.0', '7.1', '7.2']
+        ruby: ['3.4', '3.3', '3.2', '3.1']
+        rails: ['6.1', '7.0', '7.1', '7.2', '8.0']
         channel: ['stable']
 
         include:
           - ruby: 'ruby-head'
             rails: 'edge'
             channel: 'experimental'
+          - ruby: 'ruby-head'
+            rails: '8.0'
+            channel: 'experimental'
           - ruby: 'ruby-head'
             rails: '7.2'
             channel: 'experimental'
           - ruby: 'ruby-head'
             rails: '7.1'
             channel: 'experimental'
 
-          - ruby: '3.3'
+          - ruby: '3.4'
             rails: 'edge'
             channel: 'experimental'
-          - ruby: '3.2'
+          - ruby: '3.3'
             rails: 'edge'
             channel: 'experimental'
-          - ruby: '3.1'
+          - ruby: '3.2'
             rails: 'edge'
             channel: 'experimental'
 
         exclude:
-          - ruby: '3.3'
-            rails: '7.0' # TODO: works on 7-0-stable branch, remove after a 7.0.x patch release
+          - ruby: '3.4'
+            rails: '6.1'
+
           - ruby: '3.3'
             rails: '6.1'
 
           - ruby: '3.2'
             rails: '6.1'
 
+          - ruby: '3.1'
+            rails: '8.0'
+
     continue-on-error: ${{ matrix.channel != 'stable' }}
 
     env: # $BUNDLE_GEMFILE must be set at the job level, so it is set for all steps

CHANGELOG.md

@@ -1,5 +1,6 @@
 # Development (unreleased)
 
+* Release database connections after cleaning: https://github.com/DatabaseCleaner/database_cleaner-active_record/pull/122
 * Provide a 'Changelog' link on Rubygems: https://github.com/DatabaseCleaner/database_cleaner-active_record/pull/114
 * Fix bundling and CONTRIBUTE.md instructions: https://github.com/DatabaseCleaner/database_cleaner-active_record/pull/123
 * Fix order of arguments in `truncate_tables` expectation https://github.com/DatabaseCleaner/database_cleaner-active_record/pull/124

gemfiles/rails_6.1.gemfile

@@ -6,6 +6,9 @@ gem "database_cleaner-core", git: "https://github.com/DatabaseCleaner/database_c
 gem "rails", "~> 6.1.0"
 gem "sqlite3", "~> 1.5"
 gem "concurrent-ruby", "1.3.4"
+gem "logger"
+gem "mutex_m"
+gem "bigdecimal"
 
 group :test do
   gem "simplecov", require: false

gemfiles/rails_7.0.gemfile

@@ -6,6 +6,9 @@ gem "database_cleaner-core", git: "https://github.com/DatabaseCleaner/database_c
 gem "rails", "~> 7.0.0"
 gem "sqlite3", "~> 1.7"
 gem "concurrent-ruby", "1.3.4"
+gem "logger"
+gem "mutex_m"
+gem "bigdecimal"
 
 group :test do
   gem "simplecov", require: false

gemfiles/rails_7.1.gemfile

@@ -5,6 +5,9 @@ source "https://rubygems.org"
 gem "database_cleaner-core", git: "https://github.com/DatabaseCleaner/database_cleaner"
 gem "rails", "~> 7.1.0"
 gem "sqlite3", "~> 1.7"
+gem "logger"
+gem "mutex_m"
+gem "bigdecimal"
 
 group :test do
   gem "simplecov", require: false

gemfiles/rails_7.2.gemfile

@@ -4,6 +4,9 @@ source "https://rubygems.org"
 
 gem "database_cleaner-core", git: "https://github.com/DatabaseCleaner/database_cleaner"
 gem "rails", "~> 7.2.0"
+gem "logger"
+gem "mutex_m"
+gem "bigdecimal"
 
 group :test do
   gem "simplecov", require: false

gemfiles/rails_8.0.gemfile

@@ -0,0 +1,16 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "database_cleaner-core", git: "https://github.com/DatabaseCleaner/database_cleaner"
+gem "rails", "~> 8.0"
+gem "logger"
+gem "mutex_m"
+gem "bigdecimal"
+
+group :test do
+  gem "simplecov", require: false
+  gem "codecov", require: false
+end
+
+gemspec path: "../"

gemfiles/rails_edge.gemfile

@@ -4,6 +4,9 @@ source "https://rubygems.org"
 
 gem "database_cleaner-core", git: "https://github.com/DatabaseCleaner/database_cleaner"
 gem "rails", github: "rails/rails"
+gem "logger"
+gem "mutex_m"
+gem "bigdecimal"
 
 group :test do
   gem "simplecov", require: false

lib/database_cleaner/active_record/deletion.rb

@@ -9,6 +9,8 @@ def clean
             delete_tables(connection, tables_to_clean(connection))
           end
         end
+
+        connection_class.connection_pool.release_connection
       end
 
       private

lib/database_cleaner/active_record/transaction.rb

@@ -22,6 +22,8 @@ def clean
             connection.rollback_transaction
           end
         end
+
+        connection_class.connection_pool.release_connection
       end
     end
   end