Allow use of an existing SQL Connection (#31)

* allow to use an existing sql connection

Updated SqlConnectionManager and SqlServerExtensions to allow an
existing SqlConnection to be used for migrating

* update approval tests

* Updated approval due to test library change

---------

Co-authored-by: Ioannis Pinakoulakis <giannis.pin@gmail.com>

Author: droyad

src/Tests/ApprovalFiles/NoPublicApiChanges.Run.approved.cs

@@ -1,4 +1,4 @@
-[assembly: System.CLSCompliant(false)]
+[assembly: System.CLSCompliant(false)]
 [assembly: System.Reflection.AssemblyMetadata("RepositoryUrl", "https://github.com/DbUp/dbup-sqlserver.git")]
 [assembly: System.Runtime.InteropServices.ComVisible(false)]
 [assembly: System.Runtime.InteropServices.Guid("8190b40b-ac5b-414f-8a00-9b6a2c12b010")]
@@ -10,10 +10,12 @@ public static DbUp.Builder.UpgradeEngineBuilder AzureSqlDatabaseWithIntegratedSe
 public static class SqlServerExtensions
 {
     public static DbUp.Builder.UpgradeEngineBuilder JournalToSqlTable(this DbUp.Builder.UpgradeEngineBuilder builder, string schema, string table) { }
+    public static DbUp.Builder.UpgradeEngineBuilder SqlDatabase(this DbUp.Builder.SupportedDatabases supported, Microsoft.Data.SqlClient.SqlConnection connection) { }
     public static DbUp.Builder.UpgradeEngineBuilder SqlDatabase(this DbUp.Builder.SupportedDatabases supported, string connectionString) { }
     public static void SqlDatabase(this DbUp.SupportedDatabasesForDropDatabase supported, string connectionString) { }
     public static bool SqlDatabase(this DbUp.SupportedDatabasesForEnsureDatabase supported, string connectionString) { }
     public static DbUp.Builder.UpgradeEngineBuilder SqlDatabase(this DbUp.Builder.SupportedDatabases supported, DbUp.Engine.Transactions.IConnectionManager connectionManager, string schema = null) { }
+    public static DbUp.Builder.UpgradeEngineBuilder SqlDatabase(this DbUp.Builder.SupportedDatabases supported, Microsoft.Data.SqlClient.SqlConnection connection, string schema) { }
     public static DbUp.Builder.UpgradeEngineBuilder SqlDatabase(this DbUp.Builder.SupportedDatabases supported, string connectionString, string schema) { }
     public static void SqlDatabase(this DbUp.SupportedDatabasesForDropDatabase supported, string connectionString, int commandTimeout) { }
     public static bool SqlDatabase(this DbUp.SupportedDatabasesForEnsureDatabase supported, string connectionString, DbUp.SqlServer.AzureDatabaseEdition azureDatabaseEdition) { }
@@ -46,6 +48,7 @@ public override System.Collections.Generic.IEnumerable<string> SplitScriptIntoCo
     }
     public class SqlConnectionManager : DbUp.Engine.Transactions.DatabaseConnectionManager
     {
+        public SqlConnectionManager(Microsoft.Data.SqlClient.SqlConnection connection) { }
         public SqlConnectionManager(string connectionString) { }
         public override System.Collections.Generic.IEnumerable<string> SplitScriptIntoCommands(string scriptContents) { }
     }

src/dbup-sqlserver/SqlConnectionManager.cs

@@ -1,4 +1,4 @@
-using System.Collections.Generic;
+using System.Collections.Generic;
 using Microsoft.Data.SqlClient;
 using DbUp.Engine.Transactions;
 using DbUp.Support;
@@ -15,15 +15,21 @@ public class SqlConnectionManager : DatabaseConnectionManager
         /// </summary>
         /// <param name="connectionString"></param>
         public SqlConnectionManager(string connectionString)
-             : base(new DelegateConnectionFactory((log, dbManager) =>
-             {
-                 var conn = new SqlConnection(connectionString);
+            : this(new SqlConnection(connectionString))
+        { }
 
-                 if (dbManager.IsScriptOutputLogged)
-                     conn.InfoMessage += (sender, e) => log.LogInformation($"{{0}}", e.Message);
+        /// <summary>
+        /// Manages Sql Database Connections using an existing connection.
+        /// </summary>
+        /// <param name="connection">The existing SQL connection to use.</param>
+        public SqlConnectionManager(SqlConnection connection)
+            : base(new DelegateConnectionFactory((log, dbManager) =>
+            {
+                if (dbManager.IsScriptOutputLogged)
+                    connection.InfoMessage += (sender, e) => log.LogInformation($"{{0}}", e.Message);
 
-                 return conn;
-             }))
+                return connection;
+            }))
         { }
 
         /// <inheritdoc/>

src/dbup-sqlserver/SqlServerExtensions.cs

@@ -31,6 +31,19 @@ public static UpgradeEngineBuilder SqlDatabase(this SupportedDatabases supported
         return SqlDatabase(supported, connectionString, null);
     }
 
+    /// <summary>
+    /// Creates an upgrader for SQL Server databases.
+    /// </summary>
+    /// <param name="supported">Fluent helper type.</param>
+    /// <param name="connection">The sql connection.</param>
+    /// <returns>
+    /// A builder for a database upgrader designed for SQL Server databases.
+    /// </returns>
+    public static UpgradeEngineBuilder SqlDatabase(this SupportedDatabases supported, SqlConnection connection)
+    {
+        return SqlDatabase(supported, connection, null);
+    }
+
     /// <summary>
     /// Creates an upgrader for SQL Server databases.
     /// </summary>
@@ -62,6 +75,20 @@ public static UpgradeEngineBuilder SqlDatabase(this SupportedDatabases supported
         return supported.SqlDatabase(new SqlConnectionManager(connectionString), schema);
     }
 
+    /// <summary>
+    /// Creates an upgrader for SQL Server databases.
+    /// </summary>
+    /// <param name="supported">Fluent helper type.</param>
+    /// <param name="connection">The sql connection.</param>
+    /// <param name="schema">The SQL schema name to use. Defaults to 'dbo'.</param>
+    /// <returns>
+    /// A builder for a database upgrader designed for SQL Server databases.
+    /// </returns>
+    public static UpgradeEngineBuilder SqlDatabase(this SupportedDatabases supported, SqlConnection connection, string schema)
+    {
+        return SqlDatabase(new SqlConnectionManager(connection), schema);
+    }
+
     /// <summary>
     /// Creates an upgrader for SQL Server databases.
     /// </summary>