From 5fae69865825f8c7374109034933dcabe0f19604 Mon Sep 17 00:00:00 2001 From: deekshith Date: Thu, 20 Jul 2023 18:42:16 +0530 Subject: [PATCH 1/7] added a workflow to validate meta.yaml when ever a PR is made to main branch --- .github/workflows/openapi_validation.yml | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 .github/workflows/openapi_validation.yml diff --git a/.github/workflows/openapi_validation.yml b/.github/workflows/openapi_validation.yml new file mode 100644 index 00000000..d9aa313a --- /dev/null +++ b/.github/workflows/openapi_validation.yml @@ -0,0 +1,20 @@ +name: Validate OpenAPI Schema + +on: + pull_request: + branches: + - main + +jobs: + validate_openapi_schema: + name: Validate OpenAPI Schema + runs-on: ubuntu-latest + + steps: + - name: Checkout code + uses: actions/checkout@v2 + + - name: Validate OpenAPI schema + uses: thiyagu06/openapi-validator-action@v1 + with: + filepath: "./api/meta/build/meta.yaml" From ecdb11e4d17e757421cf9848d434964de40d740d Mon Sep 17 00:00:00 2001 From: deekshith Date: Thu, 20 Jul 2023 18:43:41 +0530 Subject: [PATCH 2/7] changed branch name --- .github/workflows/openapi_validation.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/openapi_validation.yml b/.github/workflows/openapi_validation.yml index d9aa313a..ce3aa45c 100644 --- a/.github/workflows/openapi_validation.yml +++ b/.github/workflows/openapi_validation.yml @@ -3,7 +3,7 @@ name: Validate OpenAPI Schema on: pull_request: branches: - - main + - master jobs: validate_openapi_schema: From 5995fe1920b09fa3e023bbbc0f1f1505a75bcdb6 Mon Sep 17 00:00:00 2001 From: deekshith Date: Thu, 20 Jul 2023 18:56:50 +0530 Subject: [PATCH 3/7] added validation status --- .github/workflows/openapi_validation.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/openapi_validation.yml b/.github/workflows/openapi_validation.yml index ce3aa45c..c454386e 100644 --- a/.github/workflows/openapi_validation.yml +++ b/.github/workflows/openapi_validation.yml @@ -18,3 +18,10 @@ jobs: uses: thiyagu06/openapi-validator-action@v1 with: filepath: "./api/meta/build/meta.yaml" + + - name: Check validation status + run: | + if [ "${{ steps.validation.outcome }}" == 'failure' ]; then + echo "OpenAPI validation failed. Blocking the pull request merge." + exit 1 + fi From 7823902d325d251aa29b5127f44a20b1b714b30f Mon Sep 17 00:00:00 2001 From: Deekshith Rathod <68671324+Deekshithrathod@users.noreply.github.com> Date: Thu, 20 Jul 2023 19:18:59 +0530 Subject: [PATCH 4/7] Update openapi_validation.yml --- .github/workflows/openapi_validation.yml | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/.github/workflows/openapi_validation.yml b/.github/workflows/openapi_validation.yml index c454386e..3740b2cc 100644 --- a/.github/workflows/openapi_validation.yml +++ b/.github/workflows/openapi_validation.yml @@ -14,14 +14,20 @@ jobs: - name: Checkout code uses: actions/checkout@v2 - - name: Validate OpenAPI schema + - name: Validate OpenAPI schema for meta.yaml + id: validate_meta uses: thiyagu06/openapi-validator-action@v1 with: filepath: "./api/meta/build/meta.yaml" - - - name: Check validation status - run: | - if [ "${{ steps.validation.outcome }}" == 'failure' ]; then - echo "OpenAPI validation failed. Blocking the pull request merge." - exit 1 - fi + + - name: Validate OpenAPI schema for registry.yaml + id: validate_registry + uses: thiyagu06/openapi-validator-action@v1 + with: + filepath: "./api/registry/build/registry.yaml" + + - name: Validate OpenAPI schema for transaction.yaml + id: validate_transaction + uses: thiyagu06/openapi-validator-action@v1 + with: + filepath: "./api/transaction/build/transaction.yaml" From c6fc031e0d3e37ad1d69c0001124578b4c011175 Mon Sep 17 00:00:00 2001 From: Deekshith Rathod <68671324+Deekshithrathod@users.noreply.github.com> Date: Thu, 20 Jul 2023 19:23:54 +0530 Subject: [PATCH 5/7] Update openapi_validation.yml --- .github/workflows/openapi_validation.yml | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/.github/workflows/openapi_validation.yml b/.github/workflows/openapi_validation.yml index 3740b2cc..f1279049 100644 --- a/.github/workflows/openapi_validation.yml +++ b/.github/workflows/openapi_validation.yml @@ -6,8 +6,8 @@ on: - master jobs: - validate_openapi_schema: - name: Validate OpenAPI Schema + validate_openapi_schema_meta: + name: Validate OpenAPI Schema for Meta runs-on: ubuntu-latest steps: @@ -19,13 +19,29 @@ jobs: uses: thiyagu06/openapi-validator-action@v1 with: filepath: "./api/meta/build/meta.yaml" - + + validate_openapi_schema_registry: + name: Validate OpenAPI Schema for registry + runs-on: ubuntu-latest + + steps: + - name: Checkout code + uses: actions/checkout@v2 + - name: Validate OpenAPI schema for registry.yaml id: validate_registry uses: thiyagu06/openapi-validator-action@v1 with: filepath: "./api/registry/build/registry.yaml" - + + validate_openapi_schema_transaction: + name: Validate OpenAPI Schema for transaction + runs-on: ubuntu-latest + + steps: + - name: Checkout code + uses: actions/checkout@v2 + - name: Validate OpenAPI schema for transaction.yaml id: validate_transaction uses: thiyagu06/openapi-validator-action@v1 From 159811b8f747d543344870eeccafc6574479ffe8 Mon Sep 17 00:00:00 2001 From: deekshith Date: Thu, 20 Jul 2023 19:26:42 +0530 Subject: [PATCH 6/7] invalid meta.yaml --- api/meta/build/meta.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/meta/build/meta.yaml b/api/meta/build/meta.yaml index 4992bd2a..36e8ccb8 100644 --- a/api/meta/build/meta.yaml +++ b/api/meta/build/meta.yaml @@ -97,7 +97,7 @@ paths: - Beckn Application Platform (BPP) description: BPP provides the list of return reasons to the BAP requestBody: - content: + content:asf application/json: schema: type: object From 2707397d4cfdcd706a3607c7f73e8aa77254091b Mon Sep 17 00:00:00 2001 From: deekshith Date: Thu, 20 Jul 2023 19:29:34 +0530 Subject: [PATCH 7/7] invalid meta --- api/meta/build/meta.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/meta/build/meta.yaml b/api/meta/build/meta.yaml index 36e8ccb8..f576cc58 100644 --- a/api/meta/build/meta.yaml +++ b/api/meta/build/meta.yaml @@ -97,7 +97,7 @@ paths: - Beckn Application Platform (BPP) description: BPP provides the list of return reasons to the BAP requestBody: - content:asf + content:asfsdaf application/json: schema: type: object