Fixed a bug that prevented saving if read_excel was used with use_openpxl_style=True, fixes #67

Author: DeepSpace2

styleframe/style_frame.py

@@ -398,14 +398,14 @@ def get_range_of_cells(row_index=None, columns=None):
             try:
                 style_to_apply = column.style.to_openpyxl_style()
             except AttributeError:
-                style_to_apply = column.style
+                style_to_apply = Styler.from_openpyxl_style(column.style, [],
+                                                            openpyxl_comment=column.style.comment).to_openpyxl_style()
             column_header_cell = sheet.cell(row=startrow + 1, column=col_index + startcol + 1)
             column_header_cell.style = style_to_apply
             if isinstance(column.style, Styler):
                 column_header_cell.comment = column.style.generate_comment()
             else:
-                if hasattr(column.style, 'comment'):
-                    column.style.comment.parent = None
+                if hasattr(column.style, 'comment') and column.style.comment is not None:
                     column_header_cell.comment = column.style.comment
             for row_index, index in enumerate(self.data_df.index):
                 current_cell = sheet.cell(row=row_index + startrow + 2, column=col_index + startcol + 1)
@@ -421,13 +421,13 @@ def get_range_of_cells(row_index=None, columns=None):
                     try:
                         style_to_apply = data_df_style.to_openpyxl_style()
                     except AttributeError:
-                        style_to_apply = data_df_style
+                        style_to_apply = Styler.from_openpyxl_style(data_df_style, [],
+                                                                    openpyxl_comment=data_df_style.comment).to_openpyxl_style()
                     current_cell.style = style_to_apply
                     if isinstance(data_df_style, Styler):
                         current_cell.comment = data_df_style.generate_comment()
                     else:
-                        if hasattr(data_df_style, 'comment'):
-                            data_df_style.comment.parent = None
+                        if hasattr(data_df_style, 'comment') and data_df_style.comment is not None:
                             current_cell.comment = data_df_style.comment
                 except AttributeError:  # if the element in the dataframe is not Container creating a default style
                     current_cell.style = Styler().to_openpyxl_style()

styleframe/tests/style_frame_tests.py

@@ -352,6 +352,22 @@ def test_read_excel_with_style_openpyxl_objects(self):
                             for row_in_excel, row_in_self in zip(rows_in_excel, rows_in_self)
                             for excel_cell, self_cell in zip(row_in_excel[1:], row_in_self[1:])))
 
+    def test_read_excel_with_style_openpyxl_objects_and_save(self):
+        self.export_and_get_default_sheet(save=True)
+        sf_from_excel = StyleFrame.read_excel(TEST_FILENAME, read_style=True, use_openpyxl_styles=True)
+        # making sure content is the same
+        self.assertTrue(all(list(self.sf[col]) == list(sf_from_excel[col]) for col in self.sf.columns))
+
+        rows_in_excel = sf_from_excel.data_df.itertuples()
+        rows_in_self = self.sf.data_df.itertuples()
+
+        # making sure styles are the same
+        self.assertTrue(all(self_cell.style == Styler.from_openpyxl_style(excel_cell.style, [])
+                            for row_in_excel, row_in_self in zip(rows_in_excel, rows_in_self)
+                            for excel_cell, self_cell in zip(row_in_excel[1:], row_in_self[1:])))
+
+        sf_from_excel.to_excel(TEST_FILENAME).save()
+
     def test_read_excel_with_style_styler_objects(self):
         self.export_and_get_default_sheet(save=True)
         sf_from_excel = StyleFrame.read_excel(TEST_FILENAME, read_style=True)