fix(filter): remove dummy "exists" property for propertyless nodes/edges

Instead of injecting a fake property, featureless elements now bypass
the filter/query system entirely and are always visible.  Replaces
per-element warnings with a single consolidated info log.

Author: Mnikley

src/graph/core.js

@@ -1027,6 +1027,11 @@ class GraphCoreManager {
     this.cache.qm.decodeQueryAndBuildAST();
 
     for (const node of this.cache.nodeRef.values()) {
+      // Nodes with no features are always visible (nothing to filter on)
+      if (node.features.size === 0) {
+        this.cache.nodeIDsToBeShown.add(node.id);
+        continue;
+      }
       if (this.cache.query.ast.testNode(node)) {
         this.cache.nodeIDsToBeShown.add(node.id);
         node.featureIsWithinThreshold.forEach((v, k) => {
@@ -1038,14 +1043,22 @@ class GraphCoreManager {
           }
         });
       }
-      // else ui.debug(`Node ${node.id} did not fulfill filter!`);
     }
 
     for (const edge of this.cache.edgeRef.values()) {
       const endsOk =
         this.cache.nodeIDsToBeShown.has(edge.source) &&
         this.cache.nodeIDsToBeShown.has(edge.target);
 
+      // Edges with no features are always visible (nothing to filter on),
+      // but still require both endpoints to be visible
+      if (edge.features.size === 0) {
+        if (endsOk) {
+          this.cache.edgeIDsToBeShown.add(edge.id);
+        }
+        continue;
+      }
+
       if (endsOk && this.cache.query.ast.testEdge(edge)) {
         this.cache.edgeIDsToBeShown.add(edge.id);
         edge.featureIsWithinThreshold.forEach((v, k) => {
@@ -1057,7 +1070,6 @@ class GraphCoreManager {
           }
         });
       }
-      // else ui.debug(`Edge ${edge.id} did not fulfill filter!`);
     }
 
     const nodeIDsToBeHidden = [...this.cache.nodeRef.keys()].filter(

src/graph/filter.js

@@ -5,7 +5,9 @@ class GraphFilterManager {
 
   async resetFilters(section, subSection = undefined) {
     const idPrefix = section + (subSection ? `::${subSection}` : "");
-    const affectedPropIDs = Array.from(this.cache.propIDs).filter(id => id.startsWith(idPrefix));
+    const affectedPropIDs = Array.from(this.cache.propIDs).filter((id) =>
+      id.startsWith(idPrefix),
+    );
 
     for (const propID of affectedPropIDs) {
       this.cache.ui.checkCheckbox(propID, true);
@@ -16,21 +18,34 @@ class GraphFilterManager {
       if (dropdown) await dropdown.selectAllCategories(true);
     }
 
-    await this.handleFilterEvent("Filtering", `Resetting filters for ${idPrefix} ..`);
+    await this.handleFilterEvent(
+      "Filtering",
+      `Resetting filters for ${idPrefix} ..`,
+    );
   }
 
-  async handleFilterEvent(header, text, propID = null, shouldResetQuery = true) {
+  async handleFilterEvent(
+    header,
+    text,
+    propID = null,
+    shouldResetQuery = true,
+  ) {
     if (shouldResetQuery) {
       this.cache.qm.resetQuery();
     }
 
     // skip rendering if property is not active
-    if (propID !== null && !this.cache.data.layouts[this.cache.data.selectedLayout].filters.get(propID).active) {
+    if (
+      propID !== null &&
+      !this.cache.data.layouts[this.cache.data.selectedLayout].filters.get(
+        propID,
+      ).active
+    ) {
       return;
     }
 
     await this.cache.ui.showLoading(header, text);
-    await new Promise(resolve => requestAnimationFrame(resolve));
+    await new Promise((resolve) => requestAnimationFrame(resolve));
 
     // Clean up manual bubble groups (remove filtered-out nodes)
     this.cache.bs.cleanupManualGroupMembers();
@@ -64,11 +79,18 @@ class GraphFilterManager {
   getPropertiesNotWithinThresholds(nodeID = null, edgeID = null) {
     const keysWithFalse = [];
     const isNode = nodeID !== null;
-    const element = isNode ? this.cache.nodeRef.get(nodeID) : this.cache.edgeRef.get(edgeID);
+    const element = isNode
+      ? this.cache.nodeRef.get(nodeID)
+      : this.cache.edgeRef.get(edgeID);
+
+    // Elements with no features are not subject to property threshold checks
+    if (element.features.size === 0) return [];
 
     // we only check properties that belong to this element type (specific props for nodes and edges)
     const availableProps = new Set([
-      ...(isNode ? this.cache.nodeExclusiveProps : this.cache.edgeExclusiveProps),
+      ...(isNode
+        ? this.cache.nodeExclusiveProps
+        : this.cache.edgeExclusiveProps),
       ...this.cache.mixedProps,
     ]);
 
@@ -103,14 +125,19 @@ class GraphFilterManager {
 
   async updateElementVisibility(idsToShow, idsToHide) {
     this.cache.visibleElementsChanged = false;
-    const {nodes, edges} = await this.cache.graph.getData();
-    const {visible, hidden} = [...nodes, ...edges].reduce((acc, item) => {
-      acc[item.style.visibility === "visible" ? 'visible' : 'hidden'].push(item.id);
-      return acc;
-    }, {visible: [], hidden: []});
-
-    const showElementsDiff = idsToShow.filter(id => hidden.includes(id));
-    const hideElementsDiff = idsToHide.filter(id => visible.includes(id));
+    const { nodes, edges } = await this.cache.graph.getData();
+    const { visible, hidden } = [...nodes, ...edges].reduce(
+      (acc, item) => {
+        acc[item.style.visibility === "visible" ? "visible" : "hidden"].push(
+          item.id,
+        );
+        return acc;
+      },
+      { visible: [], hidden: [] },
+    );
+
+    const showElementsDiff = idsToShow.filter((id) => hidden.includes(id));
+    const hideElementsDiff = idsToHide.filter((id) => visible.includes(id));
 
     if (showElementsDiff.length > 0) {
       await this.cache.graph.showElement(showElementsDiff);
@@ -123,8 +150,7 @@ class GraphFilterManager {
     if (this.cache.visibleElementsChanged) {
       this.cache.metrics.invalidateMetricValues();
     }
-
   }
 }
 
-export {GraphFilterManager};
+export { GraphFilterManager };

src/managers/io.js

@@ -1806,16 +1806,7 @@ class IOManager {
         propsAdded++;
       }
 
-      if (propsAdded === 0) {
-        this.cache.ui
-          .warning(`${descriptor} in row ${row.__rowNum__} (${nodeOrEdge.id}) has no properties. 
-      Added property 'exists' to enable display.`);
-        nodeOrEdge.D4Data[header][
-          this.cache.CFG.EXCEL_UNCATEGORIZED_SUBHEADER
-        ] = {
-          exists: true,
-        };
-      }
+      return propsAdded;
     };
 
     const nodeIDs = new Set();
@@ -1845,18 +1836,29 @@ class IOManager {
         nodeIDs.add(nodeID);
 
         addNodeOrEdgeStyle(node, row, EXCEL_NODE_PROPERTIES, descriptor);
-        addNodeOrEdgeUserData(
+        const propsAdded = addNodeOrEdgeUserData(
           node,
           row,
           EXCEL_NODE_PROPERTIES,
           this.cache.CFG.EXCEL_NODE_HEADER,
           descriptor,
         );
+        node._propsAdded = propsAdded;
 
         return node;
       })
       .filter((node) => node !== null);
 
+    const nodesWithoutProps = parsedNodes.filter((n) => n._propsAdded === 0);
+    if (nodesWithoutProps.length > 0) {
+      const ids = nodesWithoutProps.map((n) => n.id);
+      this.cache.ui.info(
+        `${nodesWithoutProps.length} node(s) have no user-defined properties and will always be visible:\n` +
+          ids.map((id) => `  - ${id}`).join("\n"),
+      );
+    }
+    parsedNodes.forEach((n) => delete n._propsAdded);
+
     const parsedEdges = edgesData
       .map((row) => {
         const edge = {};
@@ -1898,18 +1900,29 @@ class IOManager {
         edge.target = targetID;
 
         addNodeOrEdgeStyle(edge, row, EXCEL_EDGE_PROPERTIES, descriptor);
-        addNodeOrEdgeUserData(
+        const propsAdded = addNodeOrEdgeUserData(
           edge,
           row,
           EXCEL_EDGE_PROPERTIES,
           this.cache.CFG.EXCEL_EDGE_HEADER,
           descriptor,
         );
+        edge._propsAdded = propsAdded;
 
         return edge;
       })
       .filter((edge) => edge !== null);
 
+    const edgesWithoutProps = parsedEdges.filter((e) => e._propsAdded === 0);
+    if (edgesWithoutProps.length > 0) {
+      const ids = edgesWithoutProps.map((e) => e.id);
+      this.cache.ui.info(
+        `${edgesWithoutProps.length} edge(s) have no user-defined properties and will always be visible:\n` +
+          ids.map((id) => `  - ${id}`).join("\n"),
+      );
+    }
+    parsedEdges.forEach((e) => delete e._propsAdded);
+
     return {
       nodes: parsedNodes,
       edges: parsedEdges,