Skip to content

Commit f103f6c

Browse files
authored
#1204 Increase used memory size of all buildsteps (#1205)
Fixes #1204 # Description Since a week of 2 we noticed that our build pipeline was getting unstable. We tried to remedy this with moving our builds to docker containers This gave us control of what is being installed on the systems that are running our pipelines. However we noticed that some unittests/examples were still failing. @JoerivanEngelen found out that the cause of the failing tests is memory related. After a quick check I discovered that the docker container have a default memory size of 1G which is just not enough. This PR addresses that. All pipeline steps now have at least 16G. The unit tests and example pipelines have 32G. I further also increased the number of cores available the build steps. All pipelines have at least 4 cores. The unit tests and example pipelines have 8. # Checklist <!--- Before requesting review, please go through this checklist: --> - [ ] Links to correct issue - [ ] Update changelog, if changes affect users - [ ] PR title starts with ``Issue #nr``, e.g. ``Issue #737`` - [ ] Unit tests were added - [ ] **If feature added**: Added/extended example
1 parent 6da07bd commit f103f6c

5 files changed

Lines changed: 5 additions & 2 deletions

File tree

.teamcity/Templates/ExamplesTemplate.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ object ExamplesTemplate : Template({
3333
formatStderrAsError = true
3434
dockerImage = "containers.deltares.nl/hydrology_product_line_imod/windows-pixi:v0.26.1"
3535
dockerImagePlatform = ScriptBuildStep.ImagePlatform.Windows
36-
dockerRunParameters = """--cpus="4""""
36+
dockerRunParameters = """--cpus=8 --memory=32g"""
3737
dockerPull = true
3838
}
3939
}

.teamcity/Templates/LintTemplate.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ object LintTemplate : Template({
2828
formatStderrAsError = true
2929
dockerImage = "containers.deltares.nl/hydrology_product_line_imod/windows-pixi:v0.26.1"
3030
dockerImagePlatform = ScriptBuildStep.ImagePlatform.Windows
31+
dockerRunParameters = """--cpus=4 --memory=16g"""
3132
dockerPull = true
3233
}
3334
}

.teamcity/Templates/MyPyTemplate.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ object MyPyTemplate : Template({
3333
formatStderrAsError = true
3434
dockerImage = "containers.deltares.nl/hydrology_product_line_imod/windows-pixi:v0.26.1"
3535
dockerImagePlatform = ScriptBuildStep.ImagePlatform.Windows
36+
dockerRunParameters = """--cpus=4 --memory=16g"""
3637
dockerPull = true
3738
}
3839
}

.teamcity/Templates/PipPythonTemplate.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ object PipPythonTemplate : Template({
2929
formatStderrAsError = true
3030
dockerImage = "containers.deltares.nl/hydrology_product_line_imod/windows-pixi:v0.26.1"
3131
dockerImagePlatform = ScriptBuildStep.ImagePlatform.Windows
32+
dockerRunParameters = """--cpus=4 --memory=16g"""
3233
dockerPull = true
3334
}
3435
}

.teamcity/Templates/UnitTestsTemplate.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ object UnitTestsTemplate : Template({
3636
formatStderrAsError = true
3737
dockerImage = "containers.deltares.nl/hydrology_product_line_imod/windows-pixi:v0.26.1"
3838
dockerImagePlatform = ScriptBuildStep.ImagePlatform.Windows
39-
dockerRunParameters = """--cpus="4""""
39+
dockerRunParameters = """--cpus=8 --memory=32g"""
4040
dockerPull = true
4141
}
4242
powerShell {

0 commit comments

Comments
 (0)