debugblock: minimal compatibility, meta note

Author: tal5

plugin/src/main/java/com/denizenscript/denizen/scripts/commands/player/DebugBlockCommand.java

@@ -5,15 +5,15 @@
 import com.denizenscript.denizen.objects.PlayerTag;
 import com.denizenscript.denizen.utilities.BukkitImplDeprecations;
 import com.denizenscript.denizen.utilities.Utilities;
-import com.denizenscript.denizencore.objects.core.ColorTag;
-import com.denizenscript.denizencore.utilities.debugging.Debug;
 import com.denizenscript.denizencore.exceptions.InvalidArgumentsException;
 import com.denizenscript.denizencore.objects.Argument;
+import com.denizenscript.denizencore.objects.core.ColorTag;
 import com.denizenscript.denizencore.objects.core.DurationTag;
 import com.denizenscript.denizencore.objects.core.ElementTag;
 import com.denizenscript.denizencore.objects.core.ListTag;
 import com.denizenscript.denizencore.scripts.ScriptEntry;
 import com.denizenscript.denizencore.scripts.commands.AbstractCommand;
+import com.denizenscript.denizencore.utilities.debugging.Debug;
 
 import java.util.Collections;
 import java.util.List;
@@ -43,6 +43,12 @@ public DebugBlockCommand() {
     //
     // If arguments are unspecified, the default color is white, the default player is the linked player, the default name is none, and the default duration is 10 seconds.
     //
+    // Note that on MC 1.21+ this has limitations (within Minecraft itself), namely:
+    // - the color is always green.
+    // - the duration is always 10 seconds.
+    // - the name can only be a LocationTag and defaults to the debug block's location if unspecified.
+    // - debug blocks can't be cleared.
+    //
     // @Tags
     // None
     //

v1_21/src/main/java/com/denizenscript/denizen/nms/v1_21/helpers/PacketHelperImpl.java

@@ -13,6 +13,7 @@
 import com.denizenscript.denizen.utilities.maps.MapImage;
 import com.denizenscript.denizen.utilities.packets.NetworkInterceptHelper;
 import com.denizenscript.denizencore.objects.core.ColorTag;
+import com.denizenscript.denizencore.utilities.CoreUtilities;
 import com.denizenscript.denizencore.utilities.ReflectionHelper;
 import com.denizenscript.denizencore.utilities.debugging.Debug;
 import net.md_5.bungee.api.ChatColor;
@@ -353,7 +354,8 @@ public void enableNetworkManager() {
     @Override
     public void showDebugTestMarker(Player player, Location location, ColorTag color, String name, int time) {
         BlockPos nmsPos = CraftLocation.toBlockPosition(location);
-        send(player, new ClientboundGameTestHighlightPosPacket(nmsPos, nmsPos));
+        LocationTag displayPos = !name.isEmpty() ? LocationTag.valueOf(name, CoreUtilities.noDebugContext) : null;
+        send(player, new ClientboundGameTestHighlightPosPacket(nmsPos, displayPos != null ? CraftLocation.toBlockPosition(displayPos) : nmsPos));
     }
 
     @Override