Skip to content

Commit 9a26ce3

Browse files
committed
fix: bugs
1 parent b993d2f commit 9a26ce3

3 files changed

Lines changed: 20 additions & 4 deletions

File tree

src/main/java/com/code/advancedsql/ISQL.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ static List<Map<String, Object>> convertResultSetToList(ResultSet resultSet) thr
5858
list.add(row);
5959
}
6060

61+
resultSet.close();
62+
6163
return list;
6264
}
6365

src/main/java/com/code/advancedsql/query/ExecuteQuery.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,9 @@ public ResultSet fetchAll() throws SQLException {
5353
public List<Map<String, Object>> fetchAllAsList() throws SQLException {
5454
ResultSet resultSet = this.fetchAll();
5555

56-
return ISQL.convertResultSetToList(resultSet);
56+
List<Map<String, Object>> list = ISQL.convertResultSetToList(resultSet);
57+
58+
return list;
5759
}
5860

5961
/**

src/main/java/com/code/advancedsql/query/Query.java

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,23 +34,35 @@ public Boolean executeStatement() throws SQLException {
3434

3535
ISQL.setStatementParameters(this.prepare, this.execute);
3636

37-
return prepare.execute();
37+
boolean result = prepare.execute();
38+
39+
prepare.close();
40+
41+
return result;
3842
}
3943

4044
public ResultSet executeQuery() throws SQLException {
4145
prepare = this.sql.prepare(this);
4246

4347
ISQL.setStatementParameters(this.prepare, this.execute);
4448

45-
return prepare.executeQuery();
49+
ResultSet result = prepare.executeQuery();
50+
51+
prepare.close();
52+
53+
return result;
4654
}
4755

4856
public int executeUpdate() throws SQLException {
4957
prepare = this.sql.prepare(this);
5058

5159
ISQL.setStatementParameters(this.prepare, this.execute);
5260

53-
return prepare.executeUpdate();
61+
int result = prepare.executeUpdate();
62+
63+
prepare.close();
64+
65+
return result;
5466
}
5567

5668
public abstract String toQuery();

0 commit comments

Comments
 (0)