Skip to content

Route nodes created from URL strings in config / non-source files #521

Description

@azuttre

Indexing a repo that contains only config files (no source, no HTTP route definitions) creates Route nodes for arbitrary URL-like strings in those files. In a three-file repro I get four Route nodes:

  • https://app.terraform.io (a Dependabot/Terraform registry URL, from dependabot.yaml)
  • https://auth.example.com/.well-known/jwks.json (from config.yaml)
  • http://order-service:8080/v2/orders/{id} (an upstream config value, from config.yaml)
  • curl --fail http://localhost:9000/ || exit 1 (a healthcheck shell command, from compose.yaml)

None of these is a route the service serves. They inflate the route set that get_architecture and cross-repo route matching rely on, which makes that downstream matching noisier.

Repro (self-contained, generic): https://gist.github.com/azuttre/21e5e85f7590261721e3af7aa079dbfbissue-1-config-urls-as-routes.sh

Expected: no Route nodes. Got: the four strings above.

Env: v0.8.1, macOS (arm64).

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingparsing/qualityGraph extraction bugs, false positives, missing edges

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions