Skip to content

Commit 7897a9d

Browse files
Merge commit 'd3b1ec44d49366cff9ecb8449b4a214871f53ad2' into modify_livestreaming_screen
2 parents 9e40022 + d3b1ec4 commit 7897a9d

4 files changed

Lines changed: 24 additions & 7 deletions

File tree

dConnectDevicePlugin/dConnectDeviceHost/app/src/main/java/org/deviceconnect/android/deviceplugin/host/camera/CameraWrapper.java

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -551,6 +551,9 @@ public synchronized void stopRecording() throws CameraWrapperException {
551551
close();
552552
if (mIsPreview) {
553553
startPreview(mPreviewSurface, true);
554+
} else if (mIsTouchOn) {
555+
mIsTouchOn = false;
556+
turnOnTorch();
554557
}
555558
notifyCameraEvent(CameraEvent.STOPPED_VIDEO_RECORDING);
556559
}
@@ -623,17 +626,21 @@ public void onCaptureBufferLost(@NonNull CameraCaptureSession session, @NonNull
623626
}
624627
resumeRepeatingRequest();
625628
throw new CameraWrapperException(e);
629+
} finally {
630+
mIsTakingStillImage = false;
626631
}
627632
}
628633

629634
private void resumeRepeatingRequest() {
630-
mIsTakingStillImage = false;
631635

632636
try {
633637
if (mIsRecording) {
634638
startRecording(mRecordingSurface, true);
635639
} else if (mIsPreview) {
636640
startPreview(mPreviewSurface, true);
641+
} else if (mIsTouchOn) {
642+
mIsTouchOn = false;
643+
turnOnTorch();
637644
} else {
638645
close();
639646
}
@@ -794,7 +801,12 @@ public synchronized void turnOnTorch(final @Nullable TorchOnListener listener,
794801
if (mTargetSurface != null) {
795802
requestBuilder.addTarget(mTargetSurface);
796803
}
797-
} else {
804+
}
805+
if (mIsRecording) {
806+
requestBuilder.addTarget(mRecordingSurface);
807+
}
808+
809+
if (!mIsPreview && !mIsRecording) {
798810
requestBuilder.addTarget(mDummyPreviewReader.getSurface());
799811
}
800812
requestBuilder.set(CaptureRequest.FLASH_MODE, CameraMetadata.FLASH_MODE_TORCH);
@@ -848,6 +860,8 @@ public synchronized void turnOffTorch(final @Nullable TorchOffListener listener,
848860
throw new IllegalArgumentException(e);
849861
} catch (CameraWrapperException e) {
850862
throw new IllegalArgumentException(e);
863+
} finally {
864+
resumeRepeatingRequest();
851865
}
852866
notifyTorchOffEvent(listener, handler);
853867
}

dConnectDevicePlugin/dConnectDeviceHost/app/src/main/java/org/deviceconnect/android/deviceplugin/host/profile/HostMediaStreamingRecordingProfile.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -696,7 +696,8 @@ public boolean onRequest(final Intent request, final Intent response) {
696696
return true;
697697
}
698698

699-
if (recorder.getState() != HostMediaRecorder.RecorderState.INACTIVE) {
699+
if (recorder.getState() != HostMediaRecorder.RecorderState.INACTIVE
700+
&& recorder.getState() != HostMediaRecorder.RecorderState.PREVIEW) {
700701
MessageUtils.setIllegalDeviceStateError(response,
701702
recorder.getName() + " is already running.");
702703
return true;

dConnectDevicePlugin/dConnectDeviceHost/app/src/main/java/org/deviceconnect/android/deviceplugin/host/recorder/util/LiveStreamingClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public void setVideoEncoder(final @NonNull VideoEncoder videoEncoder, Integer wi
5555
videoQuality.setVideoHeight(height);
5656
}
5757
if (bitrate != null) {
58-
videoQuality.setBitRate(bitrate);
58+
videoQuality.setBitRate(bitrate * 1024);
5959
}
6060
if (frameRate != null) {
6161
videoQuality.setFrameRate(frameRate);

dConnectDevicePlugin/dConnectDeviceUVC/app/src/main/java/org/deviceconnect/android/deviceplugin/uvc/UVCDeviceService.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,11 @@ public void onDestroy() {
7878
((UVCService) service).closeUVCDevice();
7979
}
8080
}
81-
mDeviceMgr.removeDeviceListener(mDeviceListener);
82-
mDeviceMgr.removeConnectionListener(mConnectionListener);
83-
mDeviceMgr.stop();
81+
if (mDeviceMgr != null) {
82+
mDeviceMgr.removeDeviceListener(mDeviceListener);
83+
mDeviceMgr.removeConnectionListener(mConnectionListener);
84+
mDeviceMgr.stop();
85+
}
8486
unregisterReceiver(mPermissionReceiver);
8587
super.onDestroy();
8688
}

0 commit comments

Comments
 (0)