Skip to content

Commit 83248cf

Browse files
ソースコードのリファクタリング。
1 parent 71b9aef commit 83248cf

7 files changed

Lines changed: 7 additions & 9 deletions

File tree

dConnectDevicePlugin/dConnectDevicePluginSDK/dconnect-device-plugin-sdk/src/main/java/org/deviceconnect/android/profile/DConnectProfile.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ private String getInvalidParameter(final Intent request) {
263263
if (swagger != null) {
264264
Bundle extras = request.getExtras();
265265
if (extras == null) {
266-
return "";
266+
return "Unknown";
267267
}
268268
List<Parameter> parameters = OpenAPIValidator.findParameters(swagger, request);
269269
for (Parameter parameter : parameters) {
@@ -294,10 +294,8 @@ public boolean onRequest(final Intent request, final Intent response) {
294294
if (api != null) {
295295
if (!validateRequest(request)) {
296296
String invalidDetails = getInvalidParameter(request);
297-
if (invalidDetails.length() != 0) {
297+
if (!invalidDetails.equals("Unknown")) {
298298
invalidDetails = invalidDetails.substring(0, invalidDetails.length() - 1);
299-
} else {
300-
invalidDetails = "Unknown";
301299
}
302300
// API 定義ファイルでパラメータエラーとなった
303301
MessageUtils.setInvalidRequestParameterError(response, "Request parameters are invalid: " + invalidDetails);
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3035b63432ef86546145abbf2249e2ec
1+
13576ed8400fa0e614fa3b74d1c9b97a
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
96175eee0df65ec2f513f6425092bae45ebfa084
1+
8e9154b1fab7274a3b1049029e817ce5000807a8

dConnectDevicePlugin/dConnectDevicePluginSDK/repository/org/deviceconnect/dconnect-device-plugin-sdk/maven-metadata.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,6 @@
3333
<version>2.8.3</version>
3434
<version>2.8.4</version>
3535
</versions>
36-
<lastUpdated>20200323074002</lastUpdated>
36+
<lastUpdated>20200323074420</lastUpdated>
3737
</versioning>
3838
</metadata>
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
6129c9eb26dfcf2c5ebc36277d6081fd
1+
0c2169695f6c99627ad4f21a3a0a772e
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
902c94e2354b1975837e99bce9ee7779ee005095
1+
4bc103998a9d71402e7fb7c9ac169d86c89ed7d5

0 commit comments

Comments
 (0)