Fix dual-read mismatches: alias timing, key-image re-render, deepEqual null

Author: sid597

apps/roam/src/components/settings/DiscourseNodeCanvasSettings.tsx

@@ -142,13 +142,13 @@ const DiscourseNodeCanvasSettings = ({
         settingKeys={[DISCOURSE_NODE_KEYS.canvasSettings, CANVAS_KEYS.keyImage]}
         initialValue={isKeyImage}
         onChange={(checked) => {
-          setIsKeyImage(checked);
           if (checked && !keyImageOption) setKeyImageOption("first-image");
           void setInputSetting({
             blockUid: uid,
             key: "key-image",
             value: checked ? "true" : "false",
           });
+          setTimeout(() => setIsKeyImage(checked), 100);
         }}
       />
       <RadioGroup

apps/roam/src/components/settings/components/BlockPropSettingPanels.tsx

@@ -145,8 +145,10 @@ const BaseTextPanel = ({
     debounceRef.current = window.setTimeout(() => {
       if (errorRef.current) return;
       syncToBlock?.(newValue);
-      refreshConfigTree();
-      setter(settingKeys, newValue);
+      setTimeout(() => {
+        refreshConfigTree();
+        setter(settingKeys, newValue);
+      }, 100);
     }, DEBOUNCE_MS);
   };
 
@@ -232,9 +234,6 @@ const BaseFlagPanel = ({
     await syncFlagToBlock(checked);
     refreshConfigTree();
     setter(settingKeys, checked);
-    // Delay onChange to let the async Roam block.update flush before
-    // the re-render reads block props via dual-read comparison.
-    // TODO(ENG-1471): remove with dual-read cleanup
     setTimeout(() => onChange?.(checked), 100);
   };
 

apps/roam/src/components/settings/utils/accessors.ts

@@ -47,7 +47,8 @@ const isRecord = (value: unknown): value is Record<string, unknown> =>
 
 const deepEqual = (a: unknown, b: unknown): boolean => {
   if (a === b) return true;
-  const isEmpty = (v: unknown) => v === undefined || v === "" || v === false;
+  const isEmpty = (v: unknown) =>
+    v === undefined || v === null || v === "" || v === false;
   if (isEmpty(a) && isEmpty(b)) return true;
   if (a == null || b == null) return a === b;
   if (Array.isArray(a) && Array.isArray(b)) {