[BUG] Icons on the Explorer and Installed tabs.

[PsykoRider]

Before you submit

• I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
• This issue contains only one bug.

What's going wrong?

The latest update has greatly improved the display of icons in the Explorer and Installed tabs, but there are still some applications that do not load their icons.

How do we reproduce it?

No response

What did you expect?

No response

Screenshots

Your phone

Oneplus 12 & Realme GT Neo 3

Android version

Android 16 & 14

Droid-ify version

v0.7.1

Anything else?

No response

[PsykoRider]

I’ve been checking more thoroughly the icons that don’t load from the official F-Droid repository, and it’s true that in this case most of them don’t load because the icons don’t even load on the F-Droid website itself. Here are some more screenshots of the few that should load, as they do at least in the official F-Droid repository.
As for the rest of the apps, some are from other repositories, and in these cases I can’t say why the icons aren’t loading.

[Iamlooker]

This is most probably an issue with old index format, @machiav3lli am I right?

[machiav3lli]

@Iamlooker partly right… IoD has an issue with uploading icons with hashed name on first try (a scanenr bug), requiring a fall back to /icon.png (without the hashcode - check NS' code for the fallback fix). This would apply to aria2app and your local weather (maybe some other apps too - I only checked these two in NS), but most of the other apps just don't include a fiting icon in their metadata and thus can't be fixed on our side, but the devs or repo maintainers should fix this.

[PsykoRider]

@Iamlooker partly right… IoD has an issue with uploading icons with hashed name on first try (a scanenr bug), requiring a fall back to /icon.png (without the hashcode - check NS' code for the fallback fix). This would apply to aria2app and your local weather (maybe some other apps too - I only checked these two in NS), but most of the other apps just don't include a fiting icon in their metadata and thus can't be fixed on our side, but the devs or repo maintainers should fix this.

So, for apps that do display an icon on the F-Droid website, could a fix be implemented so that they display the icon in Droid-ify?

[machiav3lli]

@PsykoRider yes.

@Iamlooker are the items already composables? If so, I can include this in the patch planned for today/tomorrow

[Iamlooker]

@machiav3lli No its not composable yet. Also I have implemented a fallback. Some are still failing

[machiav3lli]

Went ahead and debugged it, the icons are there but it seems the kinda deprecated coil for Android-views seems to be facing an internal bug

Aria2App icon is https://f-droid.org/repo/com.gianlu.aria2android/en-GB/icon_SAKVG56Ft8cP5yndSJW4IjbSJN3G2j6p3_K2Wt0aT20=.png and it exists, also the catched Result (when putting breakpoints; in this interceptor) is similar to the apps that show icons. So it's mostly on the view side, this should be automatically fixed when migrated to Compose.

private class FallbackIconInterceptor : Interceptor {
    override suspend fun intercept(chain: Interceptor.Chain): ImageResult {
        val request = chain.request
        val result = chain.proceed()

        if (result is SuccessResult) return result

        val fallbackIconUrl = request.newBuilder()
            .data((request.data as String).replaceAfterLast('/', "icon.png"))
            .build()
        return chain.withRequest(fallbackIconUrl).proceed()
    }
}