Skip to content

Commit 4d1fb55

Browse files
maartenbakhalidabuhakmeh
authored andcommitted
Fix PR comment
1 parent 384a60a commit 4d1fb55

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

src/content/docs/identityserver/ui/login/dynamicproviders.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -234,11 +234,13 @@ builder.Services.ConfigureOptions<CustomConfig>();
234234

235235
:::note
236236
In your `IConfigureNamedOptions<OpenIdConnectOptions>`, you can use constructor injection to access other services.
237-
For example, if you need to access your Entity Framework Core database context to retrieve additional data for a given
238-
(dynamic) authentication scheme, you can do so if needed.
237+
Beware of performance, for example when accessing your Entity Framework Core database context here.
238+
We recommend caching any additional data you may need as part of configuring options.
239239

240-
If you require data from the `IIdentityProvider` store, you can use the `ConfigureAuthenticationOptions<>` base class
241-
to further customize your dynamic identity provider, as we'll see in the next section.
240+
Note that the `OidcProvider` class has a `Properties` bag that can be used to store additional dynamic identity provider
241+
configuration data you could use to further customize the `OpenIdConnectOptions`. When you require this (or other) data
242+
from the `IIdentityProvider` store, you can use the `ConfigureAuthenticationOptions<>` base class to further customize
243+
your dynamic identity provider, as we'll see in the next section.
242244
:::
243245

244246
### Accessing OidcProvider Data In IConfigureNamedOptions

0 commit comments

Comments
 (0)