Skip to content

Commit 57a3f2f

Browse files
authored
Updates to reflect latest 7.2 changes
1 parent 42b9c60 commit 57a3f2f

3 files changed

Lines changed: 3 additions & 49 deletions

File tree

IdentityServer/v7/docs/content/reference/options.md

Lines changed: 2 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -732,43 +732,7 @@ Duende IdentityServer may ship preview features, which can be configured using p
732732
Note that preview features can be removed and may break in future releases.
733733
{{% /notice %}}
734734

735-
When enabling a specific preview feature, you may see an error message:
736-
737-
```
738-
Error DUENDEPREVIEW001 : ‘EnableDiscoveryDocumentCacheis for evaluation
739-
purposes only and is subject to change or removal in future updates.
740-
Suppress this diagnostic to proceed.
741-
```
742-
743-
To use a preview feature, you will have to explicitly opt-in, by suppressing the preview feature's diagnostic ID.
744-
This can be done by adding a suppression in the project file, or using `#pragma warning disable` at the call site.
745-
746-
Here's an example project file using the `<NoWarn>` property to suppress the `DUENDEPREVIEW001` diagnostic:
747-
748-
```xml
749-
<Project Sdk="Microsoft.NET.Sdk.Web">
750-
751-
<!-- ... -->
752-
753-
<PropertyGroup>
754-
<!-- Opt-in to Duende IdentityServer preview features -->
755-
<NoWarn>DUENDEPREVIEW001</NoWarn>
756-
</PropertyGroup>
757-
758-
<!-- ... -->
759-
760-
</Project>
761-
```
762-
763-
Alternatively, you can suppress the warning at the call site:
764-
765-
```csharp
766-
#pragma warning disable DUENDEPREVIEW001
767-
options.Preview.EnableDiscoveryDocumentCache = true;
768-
#pragma warning enable DUENDEPREVIEW001
769-
```
770-
771-
#### DUENDEPREVIEW001
735+
#### Discovery Document Cache
772736

773737
In large deployments of Duende IdentityServer, where a lot of concurrent users attempt to
774738
consume the [discovery endpoint]({{< ref "reference/endpoints/discovery" >}}) to retrieve
@@ -780,9 +744,7 @@ This will cache discovery document information for the duration specified in the
780744
It's best to keep the cache time low if you use the `CustomEntries` element on the
781745
discovery document or implement a custom `IDiscoveryResponseGenerator`.
782746

783-
The `DUENDEPREVIEW001` diagnostic is reported when using the discovery endpoint cache.
784-
785-
#### DUENDEPREVIEW002
747+
#### Strict Audience Validation
786748

787749
When using [*private key JWT*]({{< ref "/tokens/authentication/jwt" >}}),
788750
there is a theoretical vulnerability where a Relying Party trusting multiple OpenID Providers
@@ -794,5 +756,3 @@ explicit `typ` header in the authentication JWT.
794756
You can [enable strict audience validation in Duende IdentityServer]({{< ref "/tokens/authentication/jwt#strict-audience-validation" >}})
795757
using the **StrictClientAssertionAudienceValidation** flag, which strictly validates that
796758
the audience is equal to the issuer and validates the token's `typ` header.
797-
798-
The `DUENDEPREVIEW002` diagnostic is reported when using Strict Audience Validation.

IdentityServer/v7/docs/content/tokens/authentication/jwt.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ a victim OpenID Provider.
180180
The OpenID Foundation proposed a two-part fix: strictly validate the audience and set an
181181
explicit `typ` header (with value `client-authentication+jwt`) in the authentication JWT.
182182

183-
You can enable strict audience validation using the [**StrictClientAssertionAudienceValidation**]({{< ref "/reference/options/#DUENDEPREVIEW002" >}})
183+
You can enable strict audience validation using the [**StrictClientAssertionAudienceValidation**]({{< ref "/reference/options/#strict-audience-validation" >}})
184184
flag, which strictly validates that the audience is equal to the issuer and validates the token's
185185
`typ` header.
186186

root/preview.html

Lines changed: 0 additions & 6 deletions
This file was deleted.

0 commit comments

Comments
 (0)