Unused parameter warnings

[alperaltuntas]

The MOM6 log file reports several unused parameter warnings, some of which are fixed via the following PRs:

• fix get_param STOKES_MOST and WAVE_ENHANCED_USTAR in MOM.F90  NCAR/MOM6#418
• Fix unused/deprecated parameter warnings #320

The remaining unused parameter warnings are for:

• CFC_BC_FILE
• FOX_KEMPER_ML_RESTRAT_COEF
• MLE_FRONT_LENGTH_FROM_FILE
• MEKE_RESTORING_TIMESCALE

Given that we set USE_BODNER23 = True by defaullt, I suggest we remove FOX_KEMPER_ML_RESTRAT_COEF, MLE_FRONT_LENGTH_FROM_FILE, MEKE_RESTORING_TIMESCALE from MOM_input file. Any objections? @gustavo-marques, @iangrooms

As for CFC_BC_FILE, not sure what the best solution is. @mnlevy1981?

Note: these warnings show up in GW_JRA.

[iangrooms]

I agree to remove FOX_KEMPER_ML_RESTRAT_COEF, MLE_FRONT_LENGTH_FROM_FILE, and MEKE_RESTORING_TIMESCALE. The latter is not submesoscale, but we are not using it, so it's good to remove. Thanks for finding and fixing these warnings.

[mnlevy1981]

@alperaltuntas for MARBL, we have an environment variable in env_run.xml and the MARBL defaults are only set if that variable indicates we will be running with MARBL. CFCs doesn't have that, but could ParamGen support keying defaults off of other variables in MOM_input? If so, I think you want something like

    USE_CFC_CAP:
        description: |
            "[Boolean] default = False
            If true, use the MOM_CFC_cap tracer package."
        datatype: logical
        units: Boolean
        value: False
    CFC_BC_FILE:
        description: |
            "The file in which the CFC-11 and CFC-12 atm concentrations can be found (units
            must be parts per trillion)."
        datatype: string
-       value: "${DIN_LOC_ROOT}/ocn/mom/grid_indpt/cfc_atm_20230310.nc"
+       value:
+           USE_CFC_CAP == True: "${DIN_LOC_ROOT}/ocn/mom/grid_indpt/cfc_atm_20230310.nc"

[gustavo-marques]

I also agree with removing these unused parameters. Thanks!