Clean up; Remove legacy check functions and schema

Author: cwang39403

esdlvalidator/api/models.py

@@ -24,9 +24,9 @@ class ValidationType(Enum):
 })
 
 schema_validation_check = app.api.model("check", {
-    "function": fields.String(required=True, description="Name of the registered check function to run", enum=registered_check_funcs, example="not_null"),
+    "function": fields.String(required=True, description="Name of the registered check function to run", enum=registered_check_funcs, example="attributes_validation"),
     "dataset": fields.String(required=True, description="Dataset to check on, use an alias from the selects", example="areas"),
-    "args": fields.Raw(required=True, description="Arguments passed to the check function", example={"property": "scope", "counts_as_null": ["null"]}),
+    "args": fields.Raw(required=True, description="Arguments passed to the check function", example={"null_checks": [{"attribute": "power", "count_as_null": ["0.0"]}], "valid_checks": []}),
 })
 
 schema_validation = app.api.model("validation", {

esdlvalidator/validation/functions/check_child_attribute.py

@@ -49,16 +49,15 @@ def test_instantiate_function_from_factory_wrong_param(self):
         with self.assertRaises(ValueError,):
             FunctionFactory.create(FunctionType.SELECT, "get", alias="my_alias", datasets=None, args={"this_is_an_arg": "Port"})
 
-    # TODO: fix test error
-    # def test_instantiate_function_check_from_factory(self):
-    #     """Test if the factory is able to create and initialize a check function"""
+    def test_instantiate_function_check_from_factory(self):
+        """Test if the factory is able to create and initialize a check function"""
 
-    #     mockResource = types.SimpleNamespace()
-    #     mockResource.uuid_dict = {}
-    #     datasets = {"resource": mockResource}
+        mockResource = types.SimpleNamespace()
+        mockResource.uuid_dict = {}
+        datasets = {"resource": mockResource}
 
-    #     actual = FunctionFactory.create(FunctionType.CHECK, "not_null", datasets=datasets, value=10, args={})
-    #     self.assertIsNotNone(actual, "Create function should not be None")
+        actual = FunctionFactory.create(FunctionType.CHECK, "attributes_validation", datasets=datasets, value=10, args={"null_checks": [], "valid_checks": []})
+        self.assertIsNotNone(actual, "Create function should not be None")
 
     def test_function_type_enum(self):
         """Test if the function type enum is working"""