relink.py: process_args(): Check that everything is an abs path.

Author: samsrabin

relink.py

@@ -421,6 +421,14 @@ def process_args(args):
     if hasattr(args, "items_to_process") and not isinstance(args.items_to_process, list):
         args.items_to_process = [args.items_to_process]
 
+    # Check that everything is an absolute path (should have been converted, if needed, during
+    # validate_paths).
+    if hasattr(args, "items_to_process"):
+        for item in args.items_to_process:
+            assert os.path.isabs(item)
+    if hasattr(args, "target_root"):
+        assert os.path.isabs(args.target_root)
+
     # Check that every item in items_to_process is a child of inputdata_root
     if hasattr(args, "items_to_process"):  # Sometimes doesn't if we're testing
         for item in args.items_to_process:

tests/relink/test_args.py

@@ -371,16 +371,16 @@ def test_error_if_source_not_in_inputdata(self):
         args = argparse.Namespace(
             quiet=False,
             verbose=False,
-            items_to_process="abc123",
-            inputdata_root="def456",
+            items_to_process=os.path.abspath("abc123"),
+            inputdata_root=os.path.abspath("def456"),
         )
         with pytest.raises(argparse.ArgumentTypeError) as exc_info:
             relink.process_args(args)
         assert "not under inputdata root" in str(exc_info.value)
 
     def test_error_if_target_in_inputdata(self):
         """Test that process_args errors if target is in inputdata_root."""
-        inputdata_root = "inputdata"
+        inputdata_root = os.path.abspath("inputdata")
         target_root = os.path.join(inputdata_root, "abc123")
         args = argparse.Namespace(
             quiet=False,