Avoid literal string that are not static analysable

Author: PowerKiKi

server/Application/Api/Field/Mutation/ConfirmRegistration.php

@@ -5,13 +5,15 @@
 namespace Application\Api\Field\Mutation;
 
 use Application\Api\Helper;
+use Application\Api\Input\ConfirmRegistrationInputType;
 use Application\Model\Organization;
 use Application\Model\User;
 use Application\Repository\OrganizationRepository;
 use Application\Repository\UserRepository;
 use Application\Service\MessageQueuer;
 use Ecodev\Felix\Api\ExceptionWithoutMailLogging;
 use Ecodev\Felix\Api\Field\FieldInterface;
+use Ecodev\Felix\Api\Scalar\TokenType;
 use Ecodev\Felix\Service\Mailer;
 use GraphQL\Type\Definition\Type;
 use Mezzio\Session\SessionInterface;
@@ -24,8 +26,8 @@ public static function build(): iterable
             'type' => Type::nonNull(Type::boolean()),
             'description' => 'Second step to register as a new user.',
             'args' => [
-                'token' => Type::nonNull(_types()->get('Token')),
-                'input' => Type::nonNull(_types()->get('ConfirmRegistrationInput')),
+                'token' => Type::nonNull(_types()->get(TokenType::class)),
+                'input' => Type::nonNull(_types()->get(ConfirmRegistrationInputType::class)),
             ],
             'resolve' => function ($root, array $args, SessionInterface $session): bool {
                 global $container;

server/Application/Api/Field/Mutation/CreateOrder.php

@@ -5,6 +5,7 @@
 namespace Application\Api\Field\Mutation;
 
 use Application\Api\Helper;
+use Application\Api\Input\OrderInputType;
 use Application\Enum\PaymentMethod;
 use Application\Model\Order;
 use Application\Service\Invoicer;
@@ -23,7 +24,7 @@ public static function build(): iterable
             'type' => _types()->getOutput(Order::class),
             'description' => 'Make an order to the shop.',
             'args' => [
-                'input' => Type::nonNull(_types()->get('OrderInput')),
+                'input' => Type::nonNull(_types()->get(OrderInputType::class)),
             ],
             'resolve' => function ($root, array $args, SessionInterface $session): ?Order {
                 global $container;

server/Application/Api/Field/Mutation/Import.php

@@ -5,6 +5,7 @@
 namespace Application\Api\Field\Mutation;
 
 use Application\Api\Helper;
+use Application\Api\Output\ImportResultType;
 use Application\Model\Organization;
 use Application\Service\Importer;
 use Ecodev\Felix\Api\Field\FieldInterface;
@@ -18,7 +19,7 @@ abstract class Import implements FieldInterface
     public static function build(): iterable
     {
         yield 'import' => fn () => [
-            'type' => Type::nonNull(_types()->get('ImportResult')),
+            'type' => Type::nonNull(_types()->get(ImportResultType::class)),
             'description' => 'Import a CSV file containing users',
             'args' => [
                 'file' => Type::nonNull(_types()->get(UploadType::class)),

server/Application/Api/Field/Mutation/Register.php

@@ -11,6 +11,7 @@
 use Application\Service\MessageQueuer;
 use Ecodev\Felix\Api\ExceptionWithoutMailLogging;
 use Ecodev\Felix\Api\Field\FieldInterface;
+use Ecodev\Felix\Api\Scalar\EmailType;
 use Ecodev\Felix\Service\Mailer;
 use GraphQL\Type\Definition\Type;
 use Mezzio\Session\SessionInterface;
@@ -23,7 +24,7 @@ public static function build(): iterable
             'type' => Type::nonNull(Type::boolean()),
             'description' => 'First step to register as a new user.',
             'args' => [
-                'email' => Type::nonNull(_types()->get('Email')),
+                'email' => Type::nonNull(_types()->get(EmailType::class)),
             ],
             'resolve' => function ($root, array $args, SessionInterface $session): bool {
                 global $container;

server/Application/Api/Field/Mutation/UpdateOrderLine.php

@@ -5,6 +5,7 @@
 namespace Application\Api\Field\Mutation;
 
 use Application\Api\Helper;
+use Application\Api\Input\OrderLineInputType;
 use Application\Model\OrderLine;
 use Application\Service\Invoicer;
 use Ecodev\Felix\Api\Field\FieldInterface;
@@ -21,7 +22,7 @@ public static function build(): iterable
             'description' => 'Update an existing orderLine.',
             'args' => [
                 'id' => Type::nonNull(_types()->getId(OrderLine::class)),
-                'input' => Type::nonNull(_types()->get('OrderLineInput')),
+                'input' => Type::nonNull(_types()->get(OrderLineInputType::class)),
             ],
             'resolve' => function ($root, array $args, SessionInterface $session): OrderLine {
                 global $container;

server/Application/Api/Field/Query/UserByToken.php

@@ -8,6 +8,7 @@
 use Application\Repository\UserRepository;
 use Ecodev\Felix\Api\ExceptionWithoutMailLogging;
 use Ecodev\Felix\Api\Field\FieldInterface;
+use Ecodev\Felix\Api\Scalar\TokenType;
 use GraphQL\Type\Definition\Type;
 
 abstract class UserByToken implements FieldInterface
@@ -18,7 +19,7 @@ public static function build(): iterable
             'type' => Type::nonNull(_types()->getOutput(User::class)),
             'description' => 'Get a user by its temporary token',
             'args' => [
-                'token' => Type::nonNull(_types()->get('Token')),
+                'token' => Type::nonNull(_types()->get(TokenType::class)),
             ],
             'resolve' => function ($root, array $args): User {
                 /** @var UserRepository $repository */

server/Application/Api/Input/ConfirmRegistrationInputType.php

@@ -5,6 +5,7 @@
 namespace Application\Api\Input;
 
 use Application\Model\Country;
+use Ecodev\Felix\Api\Scalar\PasswordType;
 use GraphQL\Type\Definition\InputObjectType;
 
 class ConfirmRegistrationInputType extends InputObjectType
@@ -15,7 +16,7 @@ public function __construct()
             'description' => 'Mandatory fields to complete a user registration',
             'fields' => fn (): array => [
                 'password' => [
-                    'type' => self::nonNull(_types()->get('Password')),
+                    'type' => self::nonNull(_types()->get(PasswordType::class)),
                 ],
                 'firstName' => [
                     'type' => self::nonNull(self::string()),

server/Application/Api/Input/OrderInputType.php

@@ -19,7 +19,7 @@ public function __construct()
                     'type' => self::nonNull(_types()->get('PaymentMethod')),
                 ],
                 'orderLines' => [
-                    'type' => Type::nonNull(Type::listOf(Type::nonNull(_types()->get('OrderLineInput')))),
+                    'type' => Type::nonNull(Type::listOf(Type::nonNull(_types()->get(OrderLineInputType::class)))),
                 ],
 
                 // Billing address

server/Application/Api/Input/OrderLineInputType.php

@@ -7,6 +7,7 @@
 use Application\Model\Product;
 use Application\Model\Subscription;
 use Ecodev\Felix\Api\Scalar\CHFType;
+use Ecodev\Felix\Api\Scalar\EmailType;
 use GraphQL\Type\Definition\InputObjectType;
 
 class OrderLineInputType extends InputObjectType
@@ -32,7 +33,7 @@ public function __construct()
                     'type' => _types()->getId(Subscription::class),
                 ],
                 'additionalEmails' => [
-                    'type' => self::listOf(self::nonNull(_types()->get('Email'))),
+                    'type' => self::listOf(self::nonNull(_types()->get(EmailType::class))),
                     'defaultValue' => [],
                 ],
                 'pricePerUnit' => [