Convert from yarn to npm#723
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ab5348a. Configure here.
| 'lib/io/react-native/native-bridge.js', | ||
| 'lib/node/index.js', | ||
| 'lib/util/nym.js' | ||
| ] |
There was a problem hiding this comment.
Missing ESLint build ignores
Medium Severity
Removing .eslintignore dropped global excludes for lib/, root types.js / types.mjs / types.js.flow, and android/src/main/assets/, but eslint.config.mjs only ignores a handful of lib/ files. After npm install runs prepare, npm run verify’s eslint . can lint generated build output that was never meant to be checked.
Reviewed by Cursor Bugbot for commit ab5348a. Configure here.
There was a problem hiding this comment.
Valid observation — dropping .eslintignore means only eslint.config.mjs's ignores apply. In practice lib/ and the generated types.* are produced by prepare, which ignore-scripts=true currently suppresses, so they are not present during npm run verify in CI. Flagging to the author to mirror the old excludes (lib/, types.js|mjs|js.flow, android/src/main/assets/) in the flat config if eslint . begins picking up build output; not changing it in this review pass.
8b03935 to
458c44e
Compare
socket fix --all --range-style preserve --minimum-release-age 7d --no-major-updates


CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
noneNote
Low Risk
Documentation, CI, and lockfile/tooling only; no runtime or security-sensitive application logic changes in the diff.
Overview
Switches the repo’s package manager workflow from Yarn to npm: CI runs
npm run verify, contributor docs usenpm install,npm run prepare,npm run verify,npm run fix, andnpm run startinstead of Yarn equivalents, and the v0.19.0 changelog note for core debugging is updated accordingly.Adds
.npmrcwithlegacy-peer-deps=trueandignore-scripts=true(replacing.yarnrc), and stops ignoringpackage-lock.jsonin.gitignoreso npm lockfiles are tracked.Reviewed by Cursor Bugbot for commit f5aa4ea. Bugbot is set up for automated code reviews on this repo. Configure here.