NewRadX: addressed requested changes

Author: lucass-carneiro

NewRadX/src/newradx.cxx

@@ -256,9 +256,9 @@ void NewRadX_Apply(const cGH *restrict const cctkGH,
         const auto dc_dz = vJ_dc_dz(p.I);
 
         // Global derivatives
-        const auto dgf_dx = dgf_db * db_dx + dgf_dc * dc_dx + da_dx * dgf_da;
-        const auto dgf_dy = dgf_dc * dc_dy + db_dy * dgf_db + da_dy * dgf_da;
-        const auto dgf_dz = dc_dz * dgf_dc + db_dz * dgf_db + da_dz * dgf_da;
+        const auto dgf_dx = dgf_da * da_dx + dgf_db * db_dx + dgf_dc * dc_dx;
+        const auto dgf_dy = dgf_da * da_dy + dgf_db * db_dy + dgf_dc * dc_dy;
+        const auto dgf_dz = dgf_da * da_dz + dgf_db * db_dz + dgf_dc * dc_dz;
 
         // radiative rhs
         rhs(p.I) = -vx * dgf_dx - vy * dgf_dy - vz * dgf_dz -
@@ -312,9 +312,9 @@ void NewRadX_Apply(const cGH *restrict const cctkGH,
           const auto dc_dz = vJ_dc_dz(intp);
 
           // Global derivatives at interior point
-          const auto dgf_dx = dgf_db * db_dx + dgf_dc * dc_dx + da_dx * dgf_da;
-          const auto dgf_dy = dgf_dc * dc_dy + db_dy * dgf_db + da_dy * dgf_da;
-          const auto dgf_dz = dc_dz * dgf_dc + db_dz * dgf_db + da_dz * dgf_da;
+          const auto dgf_dx = dgf_da * da_dx + dgf_db * db_dx + dgf_dc * dc_dx;
+          const auto dgf_dy = dgf_da * da_dy + dgf_db * db_dy + dgf_dc * dc_dy;
+          const auto dgf_dz = dgf_da * da_dz + dgf_db * db_dz + dgf_dc * dc_dz;
 
           // Radiative part at interior point
           const auto rad = -vxint * dgf_dx - vyint * dgf_dy - vzint * dgf_dz -

NewRadX/src/newradx.hxx

@@ -31,7 +31,38 @@ void NewRadX_Apply(const cGH *restrict const cctkGH,
 
 /**
  * @brief Applies radiative boundary condition to the RHS of a state variable
- * on multipatch grids.
+ * on multipatch grids. See above for original credits.
+ *
+ * @param cctkGH Pointer to Cactus grid hierarchy struct.
+ * @param var State variable which will have boundary conditions applied to it.
+ * @param rhs RHS of the evolution equation for @param var
+ * @param vcoordx Global x vertex coordinates grid function. Providade by
+ * CoordinatesX
+ * @param vcoordy Global y vertex coordinates grid function. Providade by
+ * CoordinatesX
+ * @param vcoordz Global z vertex coordinates grid function. Providade by
+ * CoordinatesX
+ * @param vJ_da_dx Vertex centered coordinate transformation Jacobian da/dx.
+ * Provided by any thorn implementing the Multipatch interface.
+ * @param vJ_da_dy Vertex centered coordinate transformation Jacobian da/dy.
+ * Provided by any thorn implementing the Multipatch interface.
+ * @param vJ_da_dz Vertex centered coordinate transformation Jacobian da/dz.
+ * Provided by any thorn implementing the Multipatch interface.
+ * @param vJ_db_dx Vertex centered coordinate transformation Jacobian db/dx.
+ * Provided by any thorn implementing the Multipatch interface.
+ * @param vJ_db_dy Vertex centered coordinate transformation Jacobian db/dy.
+ * Provided by any thorn implementing the Multipatch interface.
+ * @param vJ_db_dz Vertex centered coordinate transformation Jacobian db/dz.
+ * Provided by any thorn implementing the Multipatch interface.
+ * @param vJ_dc_dx Vertex centered coordinate transformation Jacobian dc/dx.
+ * Provided by any thorn implementing the Multipatch interface.
+ * @param vJ_dc_dy Vertex centered coordinate transformation Jacobian dc/dy.
+ * Provided by any thorn implementing the Multipatch interface.
+ * @param vJ_dc_dz Vertex centered coordinate transformation Jacobian dc/dz.
+ * Provided by any thorn implementing the Multipatch interface.
+ * @param var0 Value at infinity.
+ * @param v0 Propagation speed.
+ * @param radpower Radial fall-off exponent
  */
 void NewRadX_Apply(const cGH *restrict const cctkGH,
                    const Loop::GF3D2<const CCTK_REAL> &var,

scripts/spacetimex.th

@@ -182,4 +182,3 @@ SpacetimeX/TwoPuncturesX
 SpacetimeX/Weyl
 SpacetimeX/WeylScal4
 SpacetimeX/Z4c
-