Create our own Random class using the xoshiro256 algorithm

- This same algorithm can be chosen by .NET internally (and is Public Domain),
  but there is no guarantee that this is the case. By having a specific
  implementation, we can guarantee deterministic output.
- This gives access to the state of the Random object at any point via
  GetState and SetState methods that use Base64 strings. This should allow
  us to capture the RNG state if an error occurs and reproduce it as needed.
- This Random class exists in the RandomizerCore package and will take
  precedence when working inside this package. It is not a subclass of the
  System.Random class, so trying to use the wrong class somewhere will just
  not compile. It has no constructor without a seed. When we don't need to
  specify a seed, we can still use System.Random (as that implies we don't
  care about deterministic output).

Implements #395

Author: initsu

CommandLine/Program.cs

@@ -67,7 +67,7 @@ public int OnExecute()
 
         if (!Seed.HasValue) 
         {
-            var r = new Random();
+            var r = new System.Random();
             Seed = r.Next(1000000000);
         } 
         configuration!.Seed = Seed.Value.ToString();

CrossPlatformUI/ViewModels/RandomizerViewModel.cs

@@ -97,7 +97,7 @@ public RandomizerViewModel(MainViewModel main)
 
         RerollSeed = ReactiveCommand.Create(() =>
         {
-            Main.Config.Seed = new Random().Next(0, 999999999).ToString();
+            Main.Config.Seed = new System.Random().Next(0, 999999999).ToString();
         });
 
         LoadPreset = ReactiveCommand.Create<RandomizerConfiguration>(config =>

RandomizerCore/CharacterSprite.cs

@@ -56,7 +56,7 @@ public CharacterSprite(string displayName, byte[]? patch = null)
 
     public static CharacterSprite Random(CharacterSprite[] options)
     {
-        Random random = new Random();
+        System.Random random = new();
         return options[random.Next(options.Length - 1)];
     }
 };

RandomizerCore/Hyrule.cs

@@ -1,18 +1,16 @@
-using DynamicData;
-using FtRandoLib.Importer;
-using js65;
-using NLog;
-using System;
+using System;
 using System.Buffers;
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.IO;
 using System.Linq;
-using System.Reflection;
 using System.Text;
 using System.Text.Json;
 using System.Threading;
 using System.Threading.Tasks;
+using NLog;
+using js65;
+using FtRandoLib.Importer;
 using Z2Randomizer.RandomizerCore.Enemy;
 using Z2Randomizer.RandomizerCore.Overworld;
 using Z2Randomizer.RandomizerCore.Sidescroll;
@@ -174,7 +172,7 @@ public class Hyrule
     */
 
     public ROM ROMData { get; set; }
-    public Random r { get; set; }
+    public RandomizerCore.Random r { get; set; }
     public string Flags { get; private set; }
     public int SeedHash { get; private set; }
     public RandomizerProperties Props
@@ -1273,7 +1271,7 @@ private async Task<bool> FillPalaceRooms(AsmModule sideviewModule)
         try
         {
             ROM testRom = new(ROMData);
-            Random testRng = new Random();
+            Random testRng = new(SeedHash);
             //This continues to get worse, the text is based on the palaces and asm patched, so it needs to
             //be tested here, but we don't actually know what they will be until later, for now i'm just
             //testing with the vanilla text, but this could be an issue down the line.

RandomizerCore/Music.cs

@@ -158,7 +158,7 @@ public MusicRandomizer(
         bool safeOnly)
     {
         _hyrule = hyrule;
-        _shuffler = new RandomShuffler(new Random(seed));
+        _shuffler = new RandomShuffler(new System.Random(seed));
         _rom = _hyrule.ROMData.GetBytes(0, ROM.RomSize);
         _romAccess = new(_rom);
         _jsonLibPaths = new(jsonLibPaths);

RandomizerCore/ROM.cs

@@ -616,7 +616,7 @@ public void UpdateSpritePalette(NesColor tunicColor, NesColor skinTone, NesColor
 
         static int RandomUniqueColor(params int?[] forbiddenColors)
         {
-            Random random = new Random();
+            System.Random random = new();
             int color;
             do
             {
@@ -678,7 +678,7 @@ public void UpdateProjectileSprite(BeamSprites beamSprite)
     {
         if (beamSprite == BeamSprites.RANDOM)
         {
-            Random r2 = new();
+            System.Random r2 = new();
             beamSprite = (BeamSprites)r2.Next(Enum.GetValues(typeof(BeamSprites)).Length - 1);
         }