chore: bump go version to 1.23

Author: kulti

.github/workflows/ci.yml

@@ -14,7 +14,7 @@ jobs:
       - name: Set up Go 1.x
         uses: actions/setup-go@v5
         with:
-          go-version: ~1.21
+          go-version: ~1.23
         id: go
       - name: Check out code into the Go module directory
         uses: actions/checkout@v4
@@ -28,8 +28,8 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: ~1.21
+          go-version: ~1.23
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.56.2
+          version: v1.64.8

.github/workflows/tags.yml

@@ -13,7 +13,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v5
         with:
-          go-version: ~1.21
+          go-version: ~1.23
 
       - name: Create release
         id: goreleaser

.golangci.yml

@@ -6,15 +6,17 @@ linters:
   enable:
     - asciicheck
     - bodyclose
+    - copyloopvar
     # - deadcode
     # - depguard
     - dogsled
     # - dupl # some commands are looks very similar in implementation
+    - err113
     - errcheck
     - errorlint
     - exhaustive
     # - exhaustivestruct
-    - exportloopref
+    # - exportloopref
     - funlen
     - gci
     - gochecknoglobals
@@ -25,13 +27,11 @@ linters:
     - gocyclo
     - godot
     # - godox
-    - goerr113
     - gofmt
     - gofumpt
     - goheader
     - goimports
     # - golint
-    - gomnd
     - gomodguard
     - goprintffuncname
     - gosec
@@ -42,6 +42,7 @@ linters:
     - lll
     # - maligned
     - misspell
+    - mnd
     - nakedret
     - nestif
     # - nlreturn
@@ -70,7 +71,10 @@ linters-settings:
   lll:
     line-length: 110
   gci:
-    local-prefixes: github.com/enapter/enapter-cli
+      sections:
+      - standard
+      - default
+      - prefix(github.com/enapter/enapter-cli/)
 
 issues:
   exclude-rules:

go.mod

@@ -1,6 +1,7 @@
 module github.com/enapter/enapter-cli
 
-go 1.21
+go 1.23.0
+
 
 require (
 	github.com/gorilla/websocket v1.5.3

internal/app/enaptercli/cmd_device_assign_blueprint.go

@@ -56,10 +56,10 @@ func (c *cmdDevicesAssignBlueprint) Before(cliCtx *cli.Context) error {
 		return err
 	}
 	if c.blueprintID != "" && c.blueprintPath != "" {
-		return fmt.Errorf("only one of --blueprint-id or --blueprint-path can be specified")
+		return errOnlyOneBlueprinFlag
 	}
 	if c.blueprintID == "" && c.blueprintPath == "" {
-		return fmt.Errorf("one of --blueprint-id or --blueprint-path must be specified")
+		return errMissedBlueprintFlag
 	}
 	return c.validateExpandFlag(cliCtx)
 }

internal/app/enaptercli/cmd_provisioning_lua_device.go

@@ -68,10 +68,10 @@ func (c *cmdProvisioningLua) Before(cliCtx *cli.Context) error {
 		return err
 	}
 	if c.blueprintID != "" && c.blueprintPath != "" {
-		return fmt.Errorf("only one of --blueprint-id or --blueprint-path can be specified")
+		return errOnlyOneBlueprinFlag
 	}
 	if c.blueprintID == "" && c.blueprintPath == "" {
-		return fmt.Errorf("one of --blueprint-id or --blueprint-path must be specified")
+		return errMissedBlueprintFlag
 	}
 	return nil
 }

internal/app/enaptercli/errors.go

@@ -6,4 +6,6 @@ var (
 	errAPITokenMissed = errors.New("API token missing. Set it up using environment " +
 		"variable ENAPTER3_API_TOKEN")
 	errUnsupportedFlagValue = errors.New("unsupported flag value")
+	errOnlyOneBlueprinFlag  = errors.New("only one of --blueprint-id or --blueprint-path can be specified")
+	errMissedBlueprintFlag  = errors.New("one of --blueprint-id or --blueprint-path must be specified")
 )

internal/app/enaptercli/execute_test.go

@@ -23,7 +23,6 @@ func TestHelpMessages(t *testing.T) {
 	require.NoError(t, err)
 
 	for _, fi := range files {
-		fi := fi
 		t.Run(fi.Name(), func(t *testing.T) {
 			args := strings.Split(fi.Name(), " ")
 			args = append(args, "-h")
@@ -54,7 +53,6 @@ func TestHTTPReqResp(t *testing.T) {
 	require.NoError(t, err)
 
 	for _, tc := range tests {
-		tc := tc
 		t.Run(tc.Name(), func(t *testing.T) {
 			reqCount := 0
 			srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
@@ -84,9 +82,7 @@ func TestHTTPReqResp(t *testing.T) {
 			}))
 			defer srv.Close()
 
-			tmplParams := struct {
-				BaseFlags string
-			}{
+			tmplParams := struct{ BaseFlags string }{
 				BaseFlags: strings.Join([]string{"--token", testToken, "--api-host", srv.URL}, " "),
 			}