test: fix flaky mqtt adapter tests with events

The `test_standalone/test_mqtt_adapter.py` test suite used `await asyncio.sleep(0.02)` to wait for mocked methods to be called before assertions. Under higher load, or in some configurations like Python 3.13, this constant delay was insufficient, causing intermittent failures such as `AssertionError: Expected 'publish_log' to have been called`. This replaces the arbitrary sleeps with deterministic synchronization primitives (`asyncio.Event`) where tests wait explicitly for up to 1 second for the mocked function to be called before checking assertions.

Co-authored-by: rnovatorov <20299819+rnovatorov@users.noreply.github.com>

Author: google-labs-jules[bot]

tests/unit/test_standalone/test_mqtt_adapter.py

@@ -50,6 +50,8 @@ async def test_publish_properties():
     device = Device()
     mqtt_api_client = mock.AsyncMock(spec=enapter.mqtt.api.Client)
     device_channel = mock.AsyncMock(spec=enapter.mqtt.api.device.Channel)
+    event = asyncio.Event()
+    device_channel.publish_properties.side_effect = lambda *args, **kwargs: event.set()
     mqtt_api_client.device_channel.return_value = device_channel
     async with asyncio.TaskGroup() as tg:
         async with enapter.standalone.mqtt_adapter.MQTTAdapter(
@@ -59,7 +61,7 @@ async def test_publish_properties():
             device=device,
             task_group=tg,
         ):
-            await asyncio.sleep(0.02)
+            await asyncio.wait_for(event.wait(), timeout=1.0)
             device_channel.publish_properties.assert_called()
             last_call = device_channel.publish_properties.call_args
             published_properties = last_call.kwargs["properties"]
@@ -71,6 +73,8 @@ async def test_publish_telemetry():
     device = Device()
     mqtt_api_client = mock.AsyncMock(spec=enapter.mqtt.api.Client)
     device_channel = mock.AsyncMock(spec=enapter.mqtt.api.device.Channel)
+    event = asyncio.Event()
+    device_channel.publish_telemetry.side_effect = lambda *args, **kwargs: event.set()
     mqtt_api_client.device_channel.return_value = device_channel
     async with asyncio.TaskGroup() as tg:
         async with enapter.standalone.mqtt_adapter.MQTTAdapter(
@@ -80,7 +84,7 @@ async def test_publish_telemetry():
             device=device,
             task_group=tg,
         ):
-            await asyncio.sleep(0.02)
+            await asyncio.wait_for(event.wait(), timeout=1.0)
             device_channel.publish_telemetry.assert_called()
             last_call = device_channel.publish_telemetry.call_args
             published_telemetry = last_call.kwargs["telemetry"]
@@ -94,6 +98,8 @@ async def test_publish_logs(log_severity, persist_logs) -> None:
     device = Device(log_severity=log_severity, persist_logs=persist_logs)
     mqtt_api_client = mock.AsyncMock(spec=enapter.mqtt.api.Client)
     device_channel = mock.AsyncMock(spec=enapter.mqtt.api.device.Channel)
+    event = asyncio.Event()
+    device_channel.publish_log.side_effect = lambda *args, **kwargs: event.set()
     mqtt_api_client.device_channel.return_value = device_channel
     async with asyncio.TaskGroup() as tg:
         async with enapter.standalone.mqtt_adapter.MQTTAdapter(
@@ -103,7 +109,7 @@ async def test_publish_logs(log_severity, persist_logs) -> None:
             device=device,
             task_group=tg,
         ):
-            await asyncio.sleep(0.02)
+            await asyncio.wait_for(event.wait(), timeout=1.0)
             device_channel.publish_log.assert_called()
             last_call = device_channel.publish_log.call_args
             published_log = last_call.kwargs["log"]
@@ -119,7 +125,11 @@ async def test_publish_properties_exception():
     device = Device()
     mqtt_api_client = mock.AsyncMock(spec=enapter.mqtt.api.Client)
     device_channel = mock.AsyncMock(spec=enapter.mqtt.api.device.Channel)
-    device_channel.publish_properties.side_effect = RuntimeError("Publish error")
+    event = asyncio.Event()
+    def publish_properties_mock(*args, **kwargs):
+        event.set()
+        raise RuntimeError("Publish error")
+    device_channel.publish_properties.side_effect = publish_properties_mock
     mqtt_api_client.device_channel.return_value = device_channel
     async with asyncio.TaskGroup() as tg:
         async with enapter.standalone.mqtt_adapter.MQTTAdapter(
@@ -129,15 +139,19 @@ async def test_publish_properties_exception():
             device=device,
             task_group=tg,
         ):
-            await asyncio.sleep(0.02)
+            await asyncio.wait_for(event.wait(), timeout=1.0)
             device_channel.publish_properties.assert_called()
 
 
 async def test_publish_telemetry_exception():
     device = Device()
     mqtt_api_client = mock.AsyncMock(spec=enapter.mqtt.api.Client)
     device_channel = mock.AsyncMock(spec=enapter.mqtt.api.device.Channel)
-    device_channel.publish_telemetry.side_effect = RuntimeError("Publish error")
+    event = asyncio.Event()
+    def publish_telemetry_mock(*args, **kwargs):
+        event.set()
+        raise RuntimeError("Publish error")
+    device_channel.publish_telemetry.side_effect = publish_telemetry_mock
     mqtt_api_client.device_channel.return_value = device_channel
     async with asyncio.TaskGroup() as tg:
         async with enapter.standalone.mqtt_adapter.MQTTAdapter(
@@ -147,15 +161,19 @@ async def test_publish_telemetry_exception():
             device=device,
             task_group=tg,
         ):
-            await asyncio.sleep(0.02)
+            await asyncio.wait_for(event.wait(), timeout=1.0)
             device_channel.publish_telemetry.assert_called()
 
 
 async def test_publish_logs_exception():
     device = Device(log_severity="error")
     mqtt_api_client = mock.AsyncMock(spec=enapter.mqtt.api.Client)
     device_channel = mock.AsyncMock(spec=enapter.mqtt.api.device.Channel)
-    device_channel.publish_log.side_effect = RuntimeError("Publish error")
+    event = asyncio.Event()
+    def publish_log_mock(*args, **kwargs):
+        event.set()
+        raise RuntimeError("Publish error")
+    device_channel.publish_log.side_effect = publish_log_mock
     mqtt_api_client.device_channel.return_value = device_channel
     async with asyncio.TaskGroup() as tg:
         async with enapter.standalone.mqtt_adapter.MQTTAdapter(
@@ -165,7 +183,7 @@ async def test_publish_logs_exception():
             device=device,
             task_group=tg,
         ):
-            await asyncio.sleep(0.02)
+            await asyncio.wait_for(event.wait(), timeout=1.0)
             device_channel.publish_log.assert_called()