fix ghrelease workflow

Author: Encoded14

.github/workflows/build-releases.yaml

@@ -33,9 +33,6 @@ jobs:
     permissions:
       contents: write
 
-    outputs:
-      has_changes: ${{ steps.set_output.outputs.has_changes }}
-
     steps:
       - name: Prepare container
         run: |
@@ -276,77 +273,74 @@ jobs:
 
             rm -f private.pem
 
-      - name: Upload binpkgs artifact
-        if: ${{ steps.changed.outputs.pkgs != '' || steps.changed.outputs.removed != '' }}
-        uses: actions/upload-artifact@v4
-        with:
-          name: binpkgs-${{ matrix.config.arch }}
-          path: void-packages/hostdir/binpkgs/
-          retention-days: 1
-
-      - name: Set has_changes output
-        id: set_output
-        run: |
-            if [ -n "${{ steps.changed.outputs.pkgs }}" ] || [ -n "${{ steps.changed.outputs.removed }}" ]; then
-                echo "has_changes=true" >> "$GITHUB_OUTPUT"
-            else
-                echo "has_changes=false" >> "$GITHUB_OUTPUT"
-            fi
-
-  release:
-    name: Update release (${{ matrix.config.arch }})
-    runs-on: ubuntu-latest
-    needs: build
-    if: needs.build.outputs.has_changes == 'true'
-    strategy:
-      fail-fast: false
-      matrix:
-        config: *build_matrix
-
-    permissions:
-      contents: write
-
-    steps:
-      - name: Download binpkgs artifact
-        uses: actions/download-artifact@v4
-        with:
-          name: binpkgs-${{ matrix.config.arch }}
-
       - name: Update GitHub Release
+        if: ${{ steps.changed.outputs.pkgs != '' || steps.changed.outputs.removed != '' }}
         env:
           GH_TOKEN: ${{ github.token }}
-          REPO: ${{ github.repository }}
+          REPO_OWNER: ${{ github.repository_owner }}
+          REPO_NAME: ${{ github.event.repository.name }}
           TAG: repository-${{ matrix.config.arch }}
           ARCH: ${{ matrix.config.arch }}
+          API: https://api.github.com/repos/${{ github.repository_owner }}/${{ github.event.repository.name }}
+          UPLOADS: https://uploads.github.com/repos/${{ github.repository_owner }}/${{ github.event.repository.name }}
+          SHA: ${{ github.sha }}
+        working-directory: void-packages/hostdir/binpkgs/
         run: |
           set -e
-          # Create release if it doesn't exist (tag at current commit)
-          if ! gh release view "$TAG" --repo "$REPO" &>/dev/null; then
-            echo "Creating release $TAG..."
-            gh release create "$TAG" \
-              --repo "$REPO" \
-              --target "${{ github.sha }}" \
-              --title "Binary repository for $ARCH" \
-              --notes "Automated binary repository. Add with: repository=https://github.com/$REPO/releases/download/$TAG"
+          AUTH="Authorization: Bearer ${GH_TOKEN}"
+          ACCEPT="Accept: application/vnd.github+json"
+
+          # Get or create release
+          resp=$(curl -s -w "\n%{http_code}" -H "$AUTH" -H "$ACCEPT" "${API}/releases/tags/${TAG}" || true)
+          code=$(echo "$resp" | tail -n1)
+          body=$(echo "$resp" | sed '$d')
+
+          if [ "$code" = "404" ]; then
+            echo "Creating release ${TAG}..."
+            body=$(curl -s -X POST -H "$AUTH" -H "$ACCEPT" -H "Content-Type: application/json" \
+              -d "{\"tag_name\":\"${TAG}\",\"target_commitish\":\"${SHA}\",\"name\":\"Binary repository for ${ARCH}\",\"body\":\"Add with: repository=https://github.com/${REPO_OWNER}/${REPO_NAME}/releases/download/${TAG}\"}" \
+              "${API}/releases")
           else
             # Point release at latest commit
-            gh release edit "$TAG" --repo "$REPO" --target "${{ github.sha }}" 2>/dev/null || true
+            release_id=$(echo "$body" | jq -r '.id')
+            curl -s -X PATCH -H "$AUTH" -H "$ACCEPT" -H "Content-Type: application/json" \
+              -d "{\"target_commitish\":\"${SHA}\"}" \
+              "${API}/releases/${release_id}" >/dev/null || true
           fi
 
-          # List current repo files
+          release_id=$(echo "$body" | jq -r '.id')
+          [ "$release_id" = "null" ] && release_id=$(curl -s -H "$AUTH" -H "$ACCEPT" "${API}/releases/tags/${TAG}" | jq -r '.id')
+
+          # List current repo files (what we want on the release)
           ls -1 > /tmp/current_files.txt
 
-          # Upload/update: add new assets and overwrite changed ones (--clobber).
+          # Get existing asset ids by name
+          existing_assets=$(curl -s -H "$AUTH" -H "$ACCEPT" "${API}/releases/${release_id}" | jq -c '.assets[] | {id: .id, name: .name}')
+
+          # Upload each file: delete existing asset with same name (API doesn't allow overwrite), then upload
           echo "Uploading current packages and index..."
-          gh release upload "$TAG" ./* --repo "$REPO" --clobber
+          for f in *; do
+            [ -f "$f" ] || continue
+            name=$(basename "$f")
+            asset_id=$(echo "$existing_assets" | jq -r --arg n "$name" 'select(.name == $n) | .id' | head -1)
+            if [ -n "$asset_id" ] && [ "$asset_id" != "null" ]; then
+              curl -s -X DELETE -H "$AUTH" -H "$ACCEPT" "${API}/releases/assets/${asset_id}" >/dev/null || true
+            fi
+            echo "  Uploading $name"
+            curl -s -X POST -H "$AUTH" -H "$ACCEPT" -H "Content-Type: application/octet-stream" \
+              --data-binary "@${f}" \
+              "${UPLOADS}/releases/${release_id}/assets?name=${name}" >/dev/null || true
+          done
 
-          # Remove only orphan assets: old package versions and packages for removed templates
+          # Remove orphan assets (old package versions, removed templates) - get fresh asset list after uploads
           echo "Removing obsolete release assets..."
-          while read -r name; do
+          release_after=$(curl -s -H "$AUTH" -H "$ACCEPT" "${API}/releases/${release_id}")
+          echo "$release_after" | jq -r '.assets[] | "\(.name)|\(.id)"' | while IFS='|' read -r name asset_id; do
             [ -z "$name" ] && continue
             if ! grep -qxF "$name" /tmp/current_files.txt; then
               echo "  Deleting obsolete: $name"
-              gh release delete-asset "$TAG" "$name" --repo "$REPO" --yes 2>/dev/null || true
+              curl -s -X DELETE -H "$AUTH" -H "$ACCEPT" "${API}/releases/assets/${asset_id}" >/dev/null || true
             fi
-          done < <(gh release view "$TAG" --repo "$REPO" --json assets -q '.assets[].name')
-          echo "Release $TAG updated."
+          done
+
+          echo "Release ${TAG} updated."