Disallow certain values for IDs

We don't want users to name their proceses `all` or whatever as it'll break things, so let's prohibit it. I've currently prohibited empty strings, `all` and `annual` (could cause issues if a user names a season this).

Closes #548.

Author: alexdewar

src/id.rs

@@ -15,9 +15,7 @@ impl<T> IDLike for T where
 
 macro_rules! define_id_type {
     ($name:ident) => {
-        #[derive(
-            Clone, std::hash::Hash, PartialEq, Eq, serde::Deserialize, Debug, serde::Serialize,
-        )]
+        #[derive(Clone, std::hash::Hash, PartialEq, Eq, Debug, serde::Serialize)]
         /// An ID type (e.g. `AgentID`, `CommodityID`, etc.)
         pub struct $name(pub std::rc::Rc<str>);
 
@@ -45,6 +43,32 @@ macro_rules! define_id_type {
             }
         }
 
+        impl<'de> serde::Deserialize<'de> for $name {
+            fn deserialize<D>(deserialiser: D) -> std::result::Result<Self, D::Error>
+            where
+                D: serde::Deserializer<'de>,
+            {
+                use serde::de::Error;
+
+                let id: String = serde::Deserialize::deserialize(deserialiser)?;
+                let id = id.trim();
+                if id.is_empty() {
+                    return Err(D::Error::custom("IDs cannot be empty"));
+                }
+
+                const FORBIDDEN_IDS: [&str; 2] = ["all", "annual"];
+                for forbidden in FORBIDDEN_IDS.iter() {
+                    if id.eq_ignore_ascii_case(forbidden) {
+                        return Err(D::Error::custom(format!(
+                            "'{id}' is an invalid value for an ID"
+                        )));
+                    }
+                }
+
+                Ok(id.into())
+            }
+        }
+
         impl $name {
             /// Create a new ID from a string slice
             pub fn new(id: &str) -> Self {