Ran dart fix --apply

Author: M-Ahal

analysis_options.yaml

@@ -0,0 +1,305 @@
+#include: package:flutter_lints/flutter.yaml
+include: package:very_good_analysis/analysis_options.yaml
+
+analyzer:
+  errors:
+    avoid_dynamic_calls: error
+    missing_required_param: error
+    missing_return: error
+    # allow having TODOs in the code
+    todo: info
+    missing_enum_constant_in_switch: error
+    invalid_use_of_protected_member: error
+    unused_local_variable: warning
+    deprecated_member_use: warning
+    unused_element: warning
+    unused_field: warning
+    dead_code: error
+    must_call_super: error
+
+    # linter errors
+    unnecessary_statements: error
+    recursive_getters: error
+    unnecessary_new: error
+    unnecessary_getters_setters: error
+    use_function_type_syntax_for_parameters: error
+    no_duplicate_case_values: error
+    no_adjacent_strings_in_list: error
+    non_constant_identifier_names: error
+    constant_identifier_names: error
+    avoid_returning_this: error
+    prefer_const_constructors_in_immutables: error
+    prefer_const_literals_to_create_immutables: error
+    avoid_equals_and_hash_code_on_mutable_classes: error
+    camel_case_types: error
+    camel_case_extensions: error
+    library_names: error
+    file_names: error
+    library_prefixes: error
+    invalid_use_of_visible_for_testing_member: error
+    invalid_use_of_visible_for_overriding_member: error
+
+
+    # linter warnings
+    annotate_overrides: warning
+    avoid_print: warning
+    unnecessary_lambdas: warning
+    use_key_in_widget_constructors: warning
+    prefer_final_fields: warning
+    prefer_final_locals: warning
+    prefer_final_in_for_each: warning
+    prefer_const_constructors: warning
+    unnecessary_const: warning
+    unnecessary_brace_in_string_interps: warning
+    invalid_visibility_annotation: warning
+
+    # linter ignores
+    lines_longer_than_80_chars: ignore
+    always_use_package_imports: ignore
+    avoid_setters_without_getters: ignore
+    sort_constructors_first: ignore
+    public_member_api_docs: ignore
+    require_trailing_commas: ignore
+    type_annotate_public_apis: ignore
+
+  exclude:
+    - "bin/cache/**"
+    - "**/*.chopper.dart"
+    - "**/generated/**"
+    - "**/*.g.dart"
+  language:
+    strict-casts: true
+    strict-raw-types: true
+
+linter:
+  rules:
+    always_declare_return_types: true
+    always_put_control_body_on_new_line: false  # Opinionated: trade-off for conciseness is acceptable here
+    always_put_required_named_parameters_first: true
+    always_specify_types: false # Conflicts with avoid_types_on_closure_parameters
+    always_use_package_imports: false # Conflicts with prefer_relative_imports
+    annotate_overrides: true
+    annotate_redeclares: true
+    avoid_annotating_with_dynamic: true
+    avoid_bool_literals_in_conditional_expressions: true
+    avoid_catches_without_on_clauses: true
+    avoid_catching_errors: true
+    avoid_classes_with_only_static_members: false # We do this a lot
+    avoid_double_and_int_checks: true
+    avoid_dynamic_calls: true
+    avoid_empty_else: true
+    avoid_equals_and_hash_code_on_mutable_classes: true
+    avoid_escaping_inner_quotes: true
+    avoid_field_initializers_in_const_classes: true
+    avoid_final_parameters: true
+    avoid_function_literals_in_foreach_calls: true
+    avoid_futureor_void: true
+    avoid_implementing_value_types: true
+    avoid_init_to_null: true
+    avoid_js_rounded_ints: true
+    avoid_multiple_declarations_per_line: true
+    avoid_null_checks_in_equality_operators: true
+    avoid_positional_boolean_parameters: true
+    avoid_print: true
+    avoid_private_typedef_functions: true
+    avoid_redundant_argument_values: true
+    avoid_relative_lib_imports: true
+    avoid_renaming_method_parameters: true
+    avoid_return_types_on_setters: true
+    avoid_returning_null_for_void: true
+    avoid_returning_this: true
+    avoid_setters_without_getters: true
+    avoid_shadowing_type_parameters: true
+    avoid_single_cascade_in_expression_statements: true
+    avoid_slow_async_io: true
+    avoid_type_to_string: true
+    avoid_types_as_parameter_names: true
+    avoid_types_on_closure_parameters: true
+    avoid_unnecessary_containers: true
+    avoid_unused_constructor_parameters: true
+    avoid_void_async: true
+    avoid_web_libraries_in_flutter: true
+    await_only_futures: true
+    camel_case_extensions: true
+    camel_case_types: true
+    cancel_subscriptions: true
+    cascade_invocations: true
+    cast_nullable_to_non_nullable: true
+    close_sinks: true
+    collection_methods_unrelated_type: true
+    combinators_ordering: true
+    comment_references: true
+    conditional_uri_does_not_exist: true
+    constant_identifier_names: true
+    control_flow_in_finally: true
+    curly_braces_in_flow_control_structures: true
+    dangling_library_doc_comments: true
+    depend_on_referenced_packages: true
+    deprecated_consistency: true
+    deprecated_member_use_from_same_package: true
+    diagnostic_describe_all_properties: false # Opinionated: a bit much for now. Better used at a package-level
+    directives_ordering: true
+    discarded_futures: false
+    do_not_use_environment: true
+    document_ignores: true
+    empty_catches: true
+    empty_constructor_bodies: true
+    empty_statements: true
+    eol_at_end_of_file: true
+    exhaustive_cases: true
+    file_names: true
+    flutter_style_todos: true
+    hash_and_equals: true
+    implementation_imports: true
+    implicit_call_tearoffs: true
+    implicit_reopen: true
+    invalid_case_patterns: true
+    invalid_runtime_check_with_js_interop_types: true
+    join_return_with_assignment: true
+    leading_newlines_in_multiline_strings: true
+    library_annotations: true
+    library_names: true
+    library_prefixes: true
+    library_private_types_in_public_api: true
+    lines_longer_than_80_chars: true
+    literal_only_boolean_expressions: true
+    matching_super_parameters: true
+    missing_code_block_language_in_doc_comment: true
+    missing_whitespace_between_adjacent_strings: true
+    no_adjacent_strings_in_list: true
+    no_default_cases: true
+    no_duplicate_case_values: true
+    no_leading_underscores_for_library_prefixes: true
+    no_leading_underscores_for_local_identifiers: true
+    no_literal_bool_comparisons: true
+    no_logic_in_create_state: true
+    no_runtimeType_toString: true
+    no_self_assignments: true
+    no_wildcard_variable_uses: true
+    non_constant_identifier_names: true
+    noop_primitive_operations: true
+    null_check_on_nullable_type_parameter: true
+    null_closures: true
+    omit_local_variable_types: true
+    omit_obvious_local_variable_types: true
+    omit_obvious_property_types: true
+    one_member_abstracts: true
+    only_throw_errors: true
+    overridden_fields: true
+    package_names: true
+    package_prefixed_library_names: true
+    parameter_assignments: true
+    prefer_adjacent_string_concatenation: true
+    prefer_asserts_in_initializer_lists: true
+    prefer_asserts_with_message: true
+    prefer_collection_literals: true
+    prefer_conditional_assignment: true
+    prefer_const_constructors: true
+    prefer_const_constructors_in_immutables: true
+    prefer_const_declarations: true
+    prefer_const_literals_to_create_immutables: true
+    prefer_constructors_over_static_methods: true
+    prefer_contains: true
+    prefer_double_quotes: false # Conflicts with prefer_single_quotes
+    prefer_expression_function_bodies: true
+    prefer_final_fields: true
+    prefer_final_in_for_each: true
+    prefer_final_locals: true
+    prefer_final_parameters: false  # Conflicts with avoid_final_parameters. Covered by parameter_assignments.
+    prefer_for_elements_to_map_fromIterable: true
+    prefer_foreach: true
+    prefer_function_declarations_over_variables: true
+    prefer_generic_function_type_aliases: true
+    prefer_if_elements_to_conditional_expressions: true
+    prefer_if_null_operators: true
+    prefer_initializing_formals: true
+    prefer_inlined_adds: true
+    prefer_int_literals: true
+    prefer_interpolation_to_compose_strings: true
+    prefer_is_empty: true
+    prefer_is_not_empty: true
+    prefer_is_not_operator: true
+    prefer_iterable_whereType: true
+    prefer_mixin: true
+    prefer_null_aware_method_calls: true
+    prefer_null_aware_operators: true
+    prefer_relative_imports: true
+    prefer_single_quotes: true
+    prefer_spread_collections: true
+    prefer_typing_uninitialized_variables: true
+    prefer_void_to_null: true
+    provide_deprecation_message: true
+    public_member_api_docs: true
+    recursive_getters: true
+    require_trailing_commas: false  # Made obsolete due to the new Dart formatter in 3.7
+    secure_pubspec_urls: true
+    sized_box_for_whitespace: true
+    sized_box_shrink_expand: true
+    slash_for_doc_comments: true
+    sort_child_properties_last: true
+    sort_constructors_first: true
+    sort_pub_dependencies: true
+    sort_unnamed_constructors_first: true
+    specify_nonobvious_local_variable_types: false  # Conflicts with omit_local_variable_types
+    specify_nonobvious_property_types: false  # Type inference by the plugin + IDE makes this obsolete
+    strict_top_level_inference: true
+    test_types_in_equals: true
+    throw_in_finally: true
+    tighten_type_of_initializing_formals: true
+    type_annotate_public_apis: false  # Conflicts with omit_obvious_property_types. Type is inferred is usually correctly done
+    type_init_formals: true
+    type_literal_in_constant_pattern: true
+    unawaited_futures: false  # Doesn't allow the use of `.unawaited` extension
+    unintended_html_in_doc_comment: true
+    unnecessary_async: true
+    unnecessary_await_in_return: true
+    unnecessary_brace_in_string_interps: true
+    unnecessary_breaks: true
+    unnecessary_const: true
+    unnecessary_constructor_name: true
+    unnecessary_final: false
+    unnecessary_getters_setters: true
+    unnecessary_lambdas: true
+    unnecessary_late: true
+    unnecessary_library_directive: true
+    unnecessary_library_name: true
+    unnecessary_new: true
+    unnecessary_null_aware_assignments: true
+    unnecessary_null_aware_operator_on_extension_on_nullable: true
+    unnecessary_null_checks: true
+    unnecessary_null_in_if_null_operators: true
+    unnecessary_nullable_for_final_variable_declarations: true
+    unnecessary_overrides: true
+    unnecessary_parenthesis: true
+    unnecessary_raw_strings: true
+    unnecessary_statements: true
+    unnecessary_string_escapes: true
+    unnecessary_string_interpolations: true
+    unnecessary_this: true
+    unnecessary_to_list_in_spreads: true
+    unnecessary_underscores: true
+    unreachable_from_main: true
+    unrelated_type_equality_checks: true
+    unsafe_variance: false  # Too pedantic. Actually unsafe in only a handful of cases.
+    use_build_context_synchronously: true
+    use_colored_box: true
+    use_decorated_box: true
+    use_enums: true
+    use_full_hex_values_for_flutter_colors: true
+    use_function_type_syntax_for_parameters: true
+    use_if_null_to_convert_nulls_to_bools: true
+    use_is_even_rather_than_modulo: true
+    use_key_in_widget_constructors: true
+    use_late_for_private_fields_and_variables: true
+    use_named_constants: true
+    use_raw_strings: true
+    use_rethrow_when_possible: true
+    use_setters_to_change_properties: true
+    use_string_buffers: true
+    use_string_in_part_of_directives: true
+    use_super_parameters: true
+    use_test_throws_matchers: true
+    use_to_and_as_if_applicable: true
+    use_truncating_division: true
+    valid_regexps: true
+    void_checks: true

example/enough_platform_widgets_example.dart

@@ -29,14 +29,14 @@ class MyHomePage extends StatelessWidget {
   @override
   Widget build(BuildContext context) => PlatformScaffold(
         appBar: PlatformAppBar(
-          title: Text('Hello World'),
+          title: const Text('Hello World'),
         ),
         body: Column(
           crossAxisAlignment: CrossAxisAlignment.start,
           children: [
             Expanded(
               child: ListView(
-                children: [
+                children: const [
                   SelectablePlatformListTile(
                     title: Text('List Tile 1'),
                   ),

lib/cupertino.dart

@@ -1,4 +1,4 @@
-export 'src/cupertino/cupertino.dart';
-
-export 'package:cupertino_stepper/cupertino_stepper.dart';
 export 'package:cupertino_progress_bar/cupertino_progress_bar.dart';
+export 'package:cupertino_stepper/cupertino_stepper.dart';
+
+export 'src/cupertino/cupertino.dart';

lib/enough_platform_widgets.dart

@@ -1,7 +1,7 @@
 library enough_platform_widgets;
 
-export 'src/cupertino/cupertino.dart';
-export 'src/platform/platform.dart';
-
 export 'package:cupertino_stepper/cupertino_stepper.dart';
 export 'package:flutter_platform_widgets/flutter_platform_widgets.dart';
+
+export 'src/cupertino/cupertino.dart';
+export 'src/platform/platform.dart';

lib/platform.dart

@@ -1,3 +1,3 @@
-export 'src/platform/platform.dart';
-
 export 'package:flutter_platform_widgets/flutter_platform_widgets.dart';
+
+export 'src/platform/platform.dart';

lib/src/cupertino/cupertino.dart

@@ -1,12 +1,12 @@
-export 'cupertino_page_scaffold_with_toolbar.dart';
-export 'cupertino_toolbar.dart';
-export 'cupertino_page.dart';
-export 'cupertino_checkbox_list_tile.dart';
-export 'cupertino_radio_list_tile.dart';
 export 'cupertino_bar.dart';
+export 'cupertino_checkbox_list_tile.dart';
 export 'cupertino_chip.dart';
 export 'cupertino_dropdown_button.dart';
-export 'cupertino_snack_app.dart';
-export 'cupertino_multiple_segmented.dart';
 export 'cupertino_inkwell.dart';
+export 'cupertino_multiple_segmented.dart';
+export 'cupertino_page.dart';
+export 'cupertino_page_scaffold_with_toolbar.dart';
+export 'cupertino_radio_list_tile.dart';
 export 'cupertino_search.dart';
+export 'cupertino_snack_app.dart';
+export 'cupertino_toolbar.dart';

lib/src/cupertino/cupertino_checkbox_list_tile.dart

@@ -40,7 +40,7 @@ class CupertinoCheckboxListTile extends StatelessWidget {
             CupertinoIcons.circle,
             color: highlightColor,
           );
-    final padding = contentPadding ?? EdgeInsets.all(8.0);
+    final padding = contentPadding ?? const EdgeInsets.all(8.0);
     final t = title;
     final st = subtitle;
     var content = t != null && st != null
@@ -49,11 +49,7 @@ class CupertinoCheckboxListTile extends StatelessWidget {
             mainAxisSize: MainAxisSize.min,
             children: [t, st],
           )
-        : t != null
-            ? t
-            : st != null
-                ? st
-                : Container();
+        : t ?? (st ?? Container());
     if (selected) {
       content = CupertinoTheme(
         data: CupertinoThemeData(

lib/src/cupertino/cupertino_chip.dart

@@ -34,7 +34,7 @@ class CupertinoChip extends StatelessWidget {
       child: Container(
         decoration: BoxDecoration(
             border: Border.all(),
-            borderRadius: BorderRadius.all(Radius.circular(8))),
+            borderRadius: const BorderRadius.all(Radius.circular(8))),
         child: Padding(
           padding: const EdgeInsets.all(4.0),
           child: content,