prompts: improve built-in /review prompt (anomalyco#5918)

Author: elithrar

packages/opencode/src/command/template/review.txt

@@ -28,31 +28,53 @@ Use best judgement when processing input.
 
 ---
 
+## Gathering Context
+
+**Diffs alone are not enough.** After getting the diff, read the entire file(s) being modified to understand the full context. Code that looks wrong in isolation may be correct given surrounding logic—and vice versa.
+
+- Use the diff to identify which files changed
+- Read the full file to understand existing patterns, control flow, and error handling
+- Check for existing style guide or conventions files (CONVENTIONS.md, AGENTS.md, .editorconfig, etc.)
+
+---
+
 ## What to Look For
 
 **Bugs** - Your primary focus.
 - Logic errors, off-by-one mistakes, incorrect conditionals
-- Edge cases: null/empty inputs, error conditions, race conditions
+- If-else guards: missing guards, incorrect branching, unreachable code paths
+- Edge cases: null/empty/undefined inputs, error conditions, race conditions
 - Security issues: injection, auth bypass, data exposure
-- Broken error handling that swallows failures
+- Broken error handling that swallows failures, throws unexpectedly or returns error types that are not caught.
 
 **Structure** - Does the code fit the codebase?
 - Does it follow existing patterns and conventions?
 - Are there established abstractions it should use but doesn't?
+- Excessive nesting that could be flattened with early returns or extraction
 
 **Performance** - Only flag if obviously problematic.
 - O(n²) on unbounded data, N+1 queries, blocking I/O on hot paths
 
+---
+
 ## Before You Flag Something
 
-Be certain. If you're going to call something a bug, you need to be confident it actually is one.
+**Be certain.** If you're going to call something a bug, you need to be confident it actually is one.
 
 - Only review the changes - do not review pre-existing code that wasn't modified
 - Don't flag something as a bug if you're unsure - investigate first
-- Don't flag style preferences as issues
 - Don't invent hypothetical problems - if an edge case matters, explain the realistic scenario where it breaks
 - If you need more context to be sure, use the tools below to get it
 
+**Don't be a zealot about style.** When checking code against conventions:
+
+- Verify the code is *actually* in violation. Don't complain about else statements if early returns are already being used correctly.
+- Some "violations" are acceptable when they're the simplest option. A `let` statement is fine if the alternative is convoluted.
+- Excessive nesting is a legitimate concern regardless of other style choices.
+- Don't flag style preferences as issues unless they clearly violate established project conventions.
+
+---
+
 ## Tools
 
 Use these to inform your review:
@@ -63,11 +85,13 @@ Use these to inform your review:
 
 If you're uncertain about something and can't verify it with these tools, say "I'm not sure about X" rather than flagging it as a definite issue.
 
-## Tone and Approach
+---
+
+## Output
 
 1. If there is a bug, be direct and clear about why it is a bug.
-2. You should clearly communicate severity of issues, do not claim issues are more severe than they actually are.
+2. Clearly communicate severity of issues. Do not overstate severity.
 3. Critiques should clearly and explicitly communicate the scenarios, environments, or inputs that are necessary for the bug to arise. The comment should immediately indicate that the issue's severity depends on these factors.
 4. Your tone should be matter-of-fact and not accusatory or overly positive. It should read as a helpful AI assistant suggestion without sounding too much like a human reviewer.
-5. Write in a manner that allows reader to quickly understand issue without reading too closely.
+5. Write so the reader can quickly understand the issue without reading too closely.
 6. AVOID flattery, do not give any comments that are not helpful to the reader. Avoid phrasing like "Great job ...", "Thanks for ...".