Move return check into the listener (Mike's suggestion

Author: Jakubk15

chatformatter-core/src/main/java/com/eternalcode/formatter/ChatFormatterPlugin.java

@@ -62,7 +62,7 @@ public ChatFormatterPlugin(Plugin plugin) {
         server.getPluginCommand("chatformatter").setExecutor(new ChatFormatterCommand(configManager, audienceProvider, miniMessage, mentionPlayerSettings));
 
         this.mentionService = new MentionService(server, pluginConfig, mentionPlayerSettings);
-        server.getPluginManager().registerEvents(new MentionListener(mentionService), plugin);
+        server.getPluginManager().registerEvents(new MentionListener(mentionService, pluginConfig), plugin);
         server.getPluginManager().registerEvents(new MentionSuggestionsController(), plugin);
 
         server.getPluginManager().registerEvents(new UpdaterController(updaterService, pluginConfig, audienceProvider, miniMessage), plugin);

chatformatter-core/src/main/java/com/eternalcode/formatter/mention/MentionListener.java

@@ -1,5 +1,6 @@
 package com.eternalcode.formatter.mention;
 
+import com.eternalcode.formatter.config.PluginConfig;
 import org.bukkit.event.EventHandler;
 import org.bukkit.event.EventPriority;
 import org.bukkit.event.Listener;
@@ -8,13 +9,19 @@
 public class MentionListener implements Listener {
 
     private final MentionService mentionService;
+    private final PluginConfig config;
 
-    public MentionListener(MentionService mentionService) {
+    public MentionListener(MentionService mentionService, PluginConfig config) {
         this.mentionService = mentionService;
+        this.config = config;
     }
 
     @EventHandler(ignoreCancelled = true, priority = EventPriority.MONITOR)
     void onMention(AsyncPlayerChatEvent event) {
+        if (!this.config.mentions.enabled) {
+            return;
+        }
+
         this.mentionService.mentionPlayers(event.getMessage());
     }
 }

chatformatter-core/src/main/java/com/eternalcode/formatter/mention/MentionService.java

@@ -37,10 +37,6 @@ void mentionPlayers(String message) {
     }
 
     private List<Player> detectMentions(String message) {
-        if (!this.config.mentions.enabled) {
-            return List.of();
-        }
-
         List<Player> mentionedPlayers = new ArrayList<>();
 
         Matcher matcher;