Skip to content

Commit 8c9c65c

Browse files
Ramon-Jimenezclaude
andcommitted
make yarn build the data-approval build and drop mal-* naming
The build script chain still carried legacy names from the original malaria report fork (nhwa-build-folder, mal-icon.png, mal-favicon.ico, manifest_mal.json) even though this repo is now the generic Data Approval Extended app. Consolidate the build pipeline so plain 'yarn build' produces the app zip, and rename or drop the leftover mal-prefixed assets and scripts. - Collapse build-folder / nhwa-build-folder / build-default into a single build-folder + build pair driven by yarn build. - Rename mal-icon.png to app-icon.png and update the package.json manifest.webapp icon reference accordingly. - Delete public/mal-favicon.ico and public/manifest_mal.json — they were copied into build/ only to be removed again by the cleanup step, so they had no effect on the produced app. - Delete src/scripts/build.ts, which was no longer wired into any npm script and still referenced a non-existent yarn nhwa-build. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 59c3281 commit 8c9c65c

5 files changed

Lines changed: 3 additions & 45 deletions

File tree

File renamed without changes.

package.json

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,8 @@
5555
"start": "react-scripts start",
5656
"craco-start": "craco start",
5757
"prebuild": "yarn localize && yarn test",
58-
"build-folder": "rm -rf build/ && d2-manifest package.json manifest.webapp && react-scripts build && yarn run manifest && cp -r i18n icon.png build",
59-
"build-default": "REACT_APP_DHIS2_BASE_URL='' REACT_APP_DHIS2_AUTH='' yarn build-folder && rm -f $npm_package_name.zip && cd build && rm -f manifest_mal.json mal-favicon.ico && zip --quiet -r ../$npm_package_name.zip *",
60-
"nhwa-build-folder": "rm -rf build/ && d2-manifest package.json manifest.webapp && react-scripts build && yarn run manifest && cp -r i18n mal-icon.png build",
61-
"build": "REACT_APP_DHIS2_BASE_URL='' REACT_APP_DHIS2_AUTH='' yarn nhwa-build-folder && rm -f $npm_package_name.zip && cd build && rm -f manifest.json mal-favicon.ico && zip --quiet -r ../$npm_package_name.zip *",
58+
"build-folder": "rm -rf build/ && d2-manifest package.json manifest.webapp && react-scripts build && yarn run manifest && cp -r i18n app-icon.png build",
59+
"build": "REACT_APP_DHIS2_BASE_URL='' REACT_APP_DHIS2_AUTH='' yarn build-folder && rm -f $npm_package_name.zip && cd build && rm -f manifest.json && zip --quiet -r ../$npm_package_name.zip *",
6260
"test": "jest --passWithNoTests",
6361
"lint": "eslint src --ext .js,.jsx,.ts,.tsx",
6462
"eject": "react-scripts eject",
@@ -131,7 +129,7 @@
131129
"name": "Data Approval Extended",
132130
"description": "Data Approval Extended",
133131
"icons": {
134-
"48": "mal-icon.png"
132+
"48": "app-icon.png"
135133
},
136134
"developer": {
137135
"url": "https://www.eyeseetea.com/",

public/mal-favicon.ico

-95.1 KB
Binary file not shown.

public/manifest_mal.json

Lines changed: 0 additions & 15 deletions
This file was deleted.

src/scripts/build.ts

Lines changed: 0 additions & 25 deletions
This file was deleted.

0 commit comments

Comments
 (0)