OPENSTACK-2959: add function to migrate vip port

migrate vip port
1. update port device_owner "".
2. update new attrs for port.

Author: zhang-shengping

f5lbaasdriver/v2/bigip/driver_v2.py

@@ -627,7 +627,6 @@ def __init__(self, driver):
     @log_helpers.log_method_call
     def create(self, context, loadbalancer):
         """Create a loadbalancer."""
-
         self._log_entity(loadbalancer)
 
         driver = self.driver
@@ -638,7 +637,6 @@ def create(self, context, loadbalancer):
             service = {}
             agent, device = self._schedule_agent_and_device(
                 context, loadbalancer)
-            agent_host = agent['host']
             agent_config = agent.get('configurations', {})
             LOG.debug("agent configurations: %s" % agent_config)
 
@@ -647,54 +645,14 @@ def create(self, context, loadbalancer):
                 context.session.expire(agent, ['heartbeat_timestamp'])
                 LOG.info(agent)
 
-            # Update the port for the VIP to show ownership by this driver
-            port_data = {
-                'admin_state_up': True,
-                'device_owner': 'network:f5lbaasv2',
-                'status': n_const.PORT_STATUS_ACTIVE
-            }
-            port_data[portbindings.HOST_ID] = agent_host
-            port_data[portbindings.VNIC_TYPE] = "baremetal"
-
-            port_data[portbindings.PROFILE] = {}
-
-            device_info = device.get('device_info')
-
-            vip_masq_mac = device_info.get('masquerade_mac')
-            if not vip_masq_mac:
-                LOG.error(
-                    "Can not find masquerade_mac in device %s, when"
-                    " creating loadbalancer %s." % (
-                        device, loadbalancer
-                    )
-                )
-
-            # llinfo is a list of dict type
-            llinfo = device_info.get('local_link_information')
-
-            if llinfo:
-                link_info = llinfo[0]
-            else:
-                link_info = dict()
-                llinfo = [link_info]
-
-            link_info.update({"lb_mac": vip_masq_mac})
-
-            port_data[portbindings.PROFILE] = {
-                "local_link_information": llinfo
-            }
-
-            driver.plugin.db._core_plugin.update_port(
-                context,
-                loadbalancer.vip_port_id,
-                {'port': port_data}
-            )
+            self.update_vipport_attrs(context, agent, device, loadbalancer)
 
             # NOTE(qzhao): Vlan id might be assigned after updating vip
             # port. Need to build service payload after updating port.
             service = self._create_service(context, loadbalancer, agent)
             service["device"] = device
 
+            agent_host = agent['host']
             driver.agent_rpc.create_loadbalancer(
                 context, loadbalancer.to_api_dict(), service, agent_host)
         except Exception as e:
@@ -758,7 +716,71 @@ def delete(self, context, loadbalancer):
             self._handle_entity_error(context, loadbalancer.id)
             raise e
 
-    # Temporarily utilize this interface to implement loadbalancer rebuild
+    def update_vipport_attrs(self, context, agent, device, loadbalancer):
+
+        driver = self.driver
+
+        agent_host = agent["host"]
+        # Update the port for the VIP to show ownership by this driver
+        port_data = {
+            'admin_state_up': True,
+            'device_owner': 'network:f5lbaasv2',
+            'status': n_const.PORT_STATUS_ACTIVE
+        }
+        port_data[portbindings.HOST_ID] = agent_host
+        port_data[portbindings.VNIC_TYPE] = "baremetal"
+        port_data[portbindings.PROFILE] = {}
+
+        device_info = device.get('device_info')
+
+        vip_masq_mac = device_info.get('masquerade_mac')
+        if not vip_masq_mac:
+            LOG.error(
+                "Can not find masquerade_mac in device %s, when"
+                " migrating loadbalancer %s." % (
+                    device, loadbalancer
+                )
+            )
+
+        # llinfo is a list of dict type
+        llinfo = device_info.get('local_link_information')
+
+        if llinfo:
+            link_info = llinfo[0]
+        else:
+            link_info = dict()
+            llinfo = [link_info]
+
+        link_info.update({"lb_mac": vip_masq_mac})
+
+        port_data[portbindings.PROFILE] = {
+            "local_link_information": llinfo
+        }
+
+        # pzhang migrate
+        driver.plugin.db._core_plugin.update_port(
+            context,
+            loadbalancer.vip_port_id,
+            {'port': port_data}
+        )
+
+    def migrate_vipport(self, context, agent, device, loadbalancer):
+
+        driver = self.driver
+
+        LOG.info("erase device_owner of vip port %s" %
+                 loadbalancer.vip_port_id)
+
+        driver.plugin.db._core_plugin.update_port(
+            context,
+            loadbalancer.vip_port_id,
+            {"port": {"device_owner": ""}}
+        )
+
+        LOG.info("reassign attributes of vip port %s" %
+                 loadbalancer.vip_port_id)
+        self.update_vipport_attrs(context, agent, device, loadbalancer)
+
     @log_helpers.log_method_call
     def refresh(self, context, body):
         """Refresh a loadbalancer."""
@@ -780,6 +802,9 @@ def refresh(self, context, body):
             service["device"] = device
             agent_host = agent['host']
 
+            if device_id:
+                self.migrate_vipport(context, agent, device, loadbalancer)
+
             if rebuild_all:
                 self._allocate_acl_groups(context, service)
                 driver.agent_rpc.rebuild_loadbalancer(